Skip to content

src: support sync 'overlapped' stdio option - #48479

Open
bnoordhuis wants to merge 2 commits into
nodejs:mainfrom
bnoordhuis:fix48476
Open

src: support sync 'overlapped' stdio option#48479
bnoordhuis wants to merge 2 commits into
nodejs:mainfrom
bnoordhuis:fix48476

Conversation

@bnoordhuis

Copy link
Copy Markdown
Member

Fix an oversight in the pull request that introduced the 'overlapped' option to the asynchronous child process methods, and also add it to the synchronous methods, like child_process.spawnSync().

Fixes: #48476
Refs: #29412

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Jun 17, 2023
@bnoordhuis bnoordhuis added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jun 18, 2023
@github-actions github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 18, 2023
@github-actions

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✘  Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/5305271123

@bnoordhuis bnoordhuis added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels Jun 19, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Fix an oversight in the pull request that introduced the 'overlapped'
option to the asynchronous child process methods, and also add it to
the synchronous methods, like child_process.spawnSync().

Fixes: nodejs#48476
Refs: nodejs#29412
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 11, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95

aduh95 commented May 11, 2024

Copy link
Copy Markdown
Contributor

Related CI failures:

not ok 394 parallel/test-child-process-stdio-overlapped
  ---
  duration_ms: 235.92300
  severity: fail
  exitcode: 1
  stack: |-
    node:assert:408
        throw err;
        ^
    
    AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
    
      assert.ok(error)
    
        at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/test/parallel/test-child-process-stdio-overlapped.js:48:8)
        at Module._compile (node:internal/modules/cjs/loader:1434:14)
        at Module._extensions..js (node:internal/modules/cjs/loader:1518:10)
        at Module.load (node:internal/modules/cjs/loader:1249:32)
        at Module._load (node:internal/modules/cjs/loader:1065:12)
        at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:158:12)
        at node:internal/main/run_main_module:30:49 {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: undefined,
      expected: true,
      operator: '=='
    }
    
    Node.js v23.0.0-pre

@aduh95 aduh95 removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 11, 2024
@aduh95

aduh95 commented Nov 8, 2025

Copy link
Copy Markdown
Contributor

This needs a rebase

@aduh95 aduh95 added the needs-ci PRs that need a full CI run. label Nov 8, 2025
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

@github-actions github-actions Bot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026
@ehmicky

ehmicky commented Jul 28, 2026

Copy link
Copy Markdown

This PR is still relevant, please keep it up.

@github-actions github-actions Bot removed the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unreachable code reached when using {stdio: "overlapped"}

8 participants