Skip to content

[v19.x backport] src,lib: group properties used as constants from util binding - #45674

Closed
daeyeon wants to merge 2 commits into
nodejs:v19.x-stagingfrom
daeyeon:v19.x-staging.backport-45539
Closed

[v19.x backport] src,lib: group properties used as constants from util binding#45674
daeyeon wants to merge 2 commits into
nodejs:v19.x-stagingfrom
daeyeon:v19.x-staging.backport-45539

Conversation

@daeyeon

@daeyeon daeyeon commented Nov 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. v19.x labels Nov 29, 2022
@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2022
@MoLow

MoLow commented Nov 29, 2022

Copy link
Copy Markdown
Member

why is backporting needed to v19?

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@daeyeon

daeyeon commented Nov 29, 2022

Copy link
Copy Markdown
Member Author

@MoLow #45539 (comment) It's requested. Guess it's useful for removing future conflicts upon the files changed on this patch.

@targos

targos commented Nov 29, 2022

Copy link
Copy Markdown
Member

There's a chain of commits that depend on each other which started with #45125 (marked dont-land-on-v19.x).
It would probably be better to backport 066e77a first (can be done in the same PR).

joyeecheung and others added 2 commits November 29, 2022 23:17
@joyeecheung @daeyeon
util: use private symbols in JS land directly
18d9474 
Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: nodejs#45379
Backport-PR-URL: nodejs#45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
@daeyeon
src,lib: group properties used as constants from util binding
f06e8e9 
Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: nodejs#45539
Backport-PR-URL: nodejs#45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@daeyeon
daeyeon force-pushed the v19.x-staging.backport-45539 branch from 0567596 to f06e8e9 Compare November 29, 2022 14:19
@daeyeon

daeyeon commented Nov 29, 2022

Copy link
Copy Markdown
Member Author

@targos 066e77a is added also. PTAL

@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot mentioned this pull request Dec 7, 2022
Open
10 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot mentioned this pull request Dec 8, 2022
Open
8 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot mentioned this pull request Dec 9, 2022
Open
5 tasks
@nodejs-github-bot

nodejs-github-bot commented Dec 9, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48363/

This was referenced Dec 10, 2022
Open
Open
Open
@daeyeon daeyeon added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Dec 12, 2022
@daeyeon daeyeon added commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. and removed commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Dec 12, 2022
targos pushed a commit that referenced this pull request Dec 12, 2022
@joyeecheung @targos
util: use private symbols in JS land directly
8164a41 
Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
targos pushed a commit that referenced this pull request Dec 12, 2022
@daeyeon @targos
src,lib: group properties used as constants from util binding
b401800 
Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@targos

targos commented Dec 12, 2022

Copy link
Copy Markdown
Member

Landed in e8406a8...b401800

@targos targos closed this Dec 12, 2022
@github-actions github-actions Bot mentioned this pull request Dec 13, 2022
Open
13 tasks
targos pushed a commit that referenced this pull request Dec 13, 2022
@joyeecheung @targos
util: use private symbols in JS land directly
470384e 
Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
targos pushed a commit that referenced this pull request Dec 13, 2022
@daeyeon @targos
src,lib: group properties used as constants from util binding
2fbe2f9 
Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@joyeecheung @danielleadams
util: use private symbols in JS land directly
3d2bef5 
Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@daeyeon @danielleadams
src,lib: group properties used as constants from util binding
2887220 
Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@joyeecheung @danielleadams
util: use private symbols in JS land directly
3f18a83 
Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@daeyeon @danielleadams
src,lib: group properties used as constants from util binding
90e8418 
Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@joyeecheung @danielleadams
util: use private symbols in JS land directly
2bd79a3 
Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@daeyeon @danielleadams
src,lib: group properties used as constants from util binding
b02b3c8 
Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@panva panva removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@daeyeon @MoLow @nodejs-github-bot @targos @panva @joyeecheung