Skip to content

test_runner: include stack trace of uncaughtException and unhandledRejection - #44614

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
MoLow:add-stack-to-uncaught-exception
Sep 14, 2022
Merged

test_runner: include stack trace of uncaughtException and unhandledRejection#44614
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
MoLow:add-stack-to-uncaught-exception

Conversation

@MoLow

@MoLow MoLow commented Sep 12, 2022

Copy link
Copy Markdown
Member

Fixes: #44611

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 12, 2022
@MoLow

MoLow commented Sep 12, 2022

Copy link
Copy Markdown
Member Author

CC @nodejs/test_runner

@MoLow
MoLow force-pushed the add-stack-to-uncaught-exception branch from 89e8bf9 to 57c40c2 Compare September 12, 2022 13:41
aduh95
aduh95 reviewed Sep 12, 2022
View reviewed changes
Comment thread test/message/test_runner_output.js Outdated
Comment thread test/message/test_runner_output.js Outdated
cjihrig
cjihrig approved these changes Sep 12, 2022
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with an optional comment.

Comment thread lib/internal/test_runner/tap_stream.js Outdated
@MoLow MoLow added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 12, 2022
@MoLow
MoLow requested a review from aduh95 September 12, 2022 15:08
@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 12, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2022
@nodejs-github-bot

nodejs-github-bot commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46550/

aduh95
aduh95 reviewed Sep 12, 2022
View reviewed changes
Comment thread lib/internal/test_runner/test.js Outdated
@MoLow @aduh95
Update lib/internal/test_runner/test.js
e1fe810 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2022
@nodejs-github-bot

nodejs-github-bot commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46552/

@github-actions github-actions Bot mentioned this pull request Sep 13, 2022
Open
30 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46555/

@github-actions github-actions Bot mentioned this pull request Sep 14, 2022
Open
28 tasks
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 14, 2022
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/44614
✔  Done loading data for nodejs/node/pull/44614
----------------------------------- PR info ------------------------------------
Title      test_runner: include stack trace of `uncaughtException` and `unhandledRejection` (#44614)
Author     Moshe Atlow  (@MoLow)
Branch     MoLow:add-stack-to-uncaught-exception -> nodejs:main
Labels     author ready, needs-ci, dont-land-on-v14.x, commit-queue-squash, test_runner
Commits    3
 - test_runner: include stack of uncaught exceptions
 - CR
 - Update lib/internal/test_runner/test.js
Committers 2
 - Moshe Atlow 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/44614
Fixes: https://github.com/nodejs/node/issues/44611
Reviewed-By: Colin Ihrig 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44614
Fixes: https://github.com/nodejs/node/issues/44611
Reviewed-By: Colin Ihrig 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 12 Sep 2022 13:38:19 GMT
   ✔  Approvals: 3
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/44614#pullrequestreview-1104195009
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/44614#pullrequestreview-1104368917
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/44614#pullrequestreview-1104853604
   ✖  This PR needs to wait 3 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-09-13T04:00:09Z: https://ci.nodejs.org/job/node-test-pull-request/46555/
- Querying data for job/node-test-pull-request/46555/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3051969053

@MoLow MoLow removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 14, 2022
@github-actions github-actions Bot mentioned this pull request Sep 15, 2022
Open
29 tasks
This was referenced Sep 16, 2022
Open
Open
Open
@RafaelGSS RafaelGSS mentioned this pull request Sep 26, 2022
Merged
@MoLow
MoLow deleted the add-stack-to-uncaught-exception branch October 3, 2022 10:12
@MoLow MoLow mentioned this pull request Oct 3, 2022
Closed
@juanarbol juanarbol mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@cjihrig cjihrig cjihrig approved these changes
@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test runner naively rethrows non-testing error without preserving stack trace

5 participants

@MoLow @nodejs-github-bot @benjamingr @cjihrig @aduh95