tools: enable prefer-object-has-own lint rule - #41245
Merged
Merged
Conversation
Trott
added
fast-track
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
nodejs-github-bot
added
needs-ci
github-actions
Bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Dec 19, 2021
aduh95
approved these changes
Dec 19, 2021
tniessen
approved these changes
Dec 19, 2021
lpinca
approved these changes
Dec 19, 2021
Trott
force-pushed
the
prefer-has-own
branch
from
December 20, 2021 04:52
3ba9f42 to
b0c4620
Compare
github-actions
Bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
aduh95
approved these changes
Dec 20, 2021
Collaborator
aduh95
added
the
author ready
BridgeAR
approved these changes
Dec 20, 2021
cjihrig
approved these changes
Dec 20, 2021
Collaborator
22 tasks
Trott
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 340998e |
This was referenced Dec 22, 2021
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41245 Refs: https://eslint.org/docs/rules/prefer-object-has-own Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41245 Refs: https://eslint.org/docs/rules/prefer-object-has-own Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit is from #41229.Second commit enables the lint rule.Ref: https://eslint.org/docs/rules/prefer-object-has-own