Skip to content

test: fix skip message for test-macos-app-sandbox#38114

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:fix-msg-test-macos-app-sandbox
Closed

test: fix skip message for test-macos-app-sandbox#38114
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:fix-msg-test-macos-app-sandbox

Conversation

@tniessen

@tniessen tniessen commented Apr 6, 2021

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 6, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 72 hours to land. and removed needs-ci PRs that need a full CI run. labels Apr 6, 2021
@aduh95

aduh95 commented Apr 6, 2021

Copy link
Copy Markdown
Contributor

fast-track?

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2021

Copy link
Copy Markdown
Collaborator

@jasnell

jasnell commented Apr 7, 2021

Copy link
Copy Markdown
Member

Landed in 6a6cdfa

@jasnell jasnell closed this Apr 7, 2021
jasnell pushed a commit that referenced this pull request Apr 7, 2021
PR-URL: #38114
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 8, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #38114
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
@tniessen tniessen deleted the fix-msg-test-macos-app-sandbox branch October 7, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 72 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants