test: improve WASI options validation - #30800
Merged
Merged
Conversation
nodejs-github-bot
added
the
test
BridgeAR
approved these changes
Dec 5, 2019
Trott
added
the
author ready
Collaborator
cjihrig
approved these changes
Dec 5, 2019
lpinca
approved these changes
Dec 5, 2019
jasnell
approved these changes
Dec 5, 2019
trivikr
approved these changes
Dec 7, 2019
Trott
force-pushed
the
wasi-validation
branch
from
December 7, 2019 17:03
ae5d160 to
147317f
Compare
Member
Author
|
Landed in 147317f |
targos
pushed a commit
that referenced
this pull request
Dec 9, 2019
Refs: https://github.com/nodejs/node/pull/30770/files#r353051438 PR-URL: #30800 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Refs: https://github.com/nodejs/node/pull/30770/files#r353051438 PR-URL: #30800 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Refs: https://github.com/nodejs/node/pull/30770/files#r353051438 PR-URL: #30800 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs/node/pull/30770/files#r353051438
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes