crypto: simplify GetPublicOrPrivateKeyFromJs - #26454
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Mar 5, 2019
bnoordhuis
left a comment
bnoordhuis
left a comment
Member
There was a problem hiding this comment.
LGTM. I felt it should have been an enum in the first place. :-)
addaleax
approved these changes
Mar 5, 2019
lpinca
approved these changes
Mar 5, 2019
jasnell
approved these changes
Mar 5, 2019
BridgeAR
approved these changes
Mar 5, 2019
Member
BridgeAR
added
the
author ready
shisama
approved these changes
Mar 6, 2019
Contributor
|
Resume build: https://ci.nodejs.org/job/node-test-pull-request/21247/ |
Member
Author
|
Resume build: https://ci.nodejs.org/job/node-test-pull-request/21261/ |
Member
Author
|
Thanks for reviewing, everyone! Landed in 3e4e518. |
tniessen
added a commit
that referenced
this pull request
Mar 7, 2019
PR-URL: #26454 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
PR-URL: nodejs#26454 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
PR-URL: #26454 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
tniessen
removed
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last argument is now always set to
truedue to #26278. This change removes said argument and its only usage in an assertion.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes