Repository navigation
Conversation
Contributor
|
Did you mean to close #2151? |
yjhjstz
force-pushed
the
master-fix-debugger
branch
from
August 31, 2015 07:36
69cbbc4 to
f811e80
Compare
Author
|
yes @thefourtheye , update PR #2151 in this pr , and add close handles. @indutny |
Contributor
|
ping @indutny |
|
Ditto ping @indutny, the inability to take a process out of debugging mode is a blocking issue on the project I am working on. |
Member
There was a problem hiding this comment.
minor nit: can you change the require() statements to use const
yjhjstz
force-pushed
the
master-fix-debugger
branch
from
January 25, 2016 07:12
f811e80 to
fe502d5
Compare
Author
|
any other suggestion? |
Member
There was a problem hiding this comment.
You don't need to add a method for this, you can just use a lambda function (or even reinterpret_cast<uv_walk_cb>(uv_close), although that's a bit of a hack.)
yjhjstz
force-pushed
the
master-fix-debugger
branch
from
February 16, 2016 07:12
fe502d5 to
47c346d
Compare
Contributor
There was a problem hiding this comment.
Can you make this common.fail().
yjhjstz
force-pushed
the
master-fix-debugger
branch
from
February 17, 2016 01:45
47c346d to
0f34fed
Compare
yjhjstz
force-pushed
the
master-fix-debugger
branch
from
February 17, 2016 05:48
0f34fed to
e0c48b7
Compare
Author
|
rebase and reopen #5270 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #2110
Call
uv_walkto close all handles， otherwise would meat error below.