Skip to content

test: replaced anonymous closure functions to arrow functions - #24417

Closed
Amanpreet-03 wants to merge 1 commit into
nodejs:masterfrom
Amanpreet-03:master
Closed

test: replaced anonymous closure functions to arrow functions#24417
Amanpreet-03 wants to merge 1 commit into
nodejs:masterfrom
Amanpreet-03:master

Conversation

@Amanpreet-03

@Amanpreet-03 Amanpreet-03 commented Nov 17, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Nov 17, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
@Amanpreet-03 Amanpreet-03 changed the title Replaced anonymous closure functions to arrow functions test: replaced anonymous closure functions to arrow functions Nov 17, 2018
targos
targos approved these changes Nov 17, 2018
View reviewed changes

@targos targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Commit message nit: s/replaced/replace/

@targos targos added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 17, 2018
@targos

targos commented Nov 17, 2018

Copy link
Copy Markdown
Member

👍 to fast-track

@Trott

Trott commented Nov 19, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18744/

@Trott

Trott commented Nov 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Landed in 35b996d

@Trott Trott closed this Nov 19, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 19, 2018
@Amanpreet-03 @Trott
test: replace anonymous closure functions with arrow function
35b996d 
PR-URL: nodejs#24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 19, 2018
@Amanpreet-03 @targos
test: replace anonymous closure functions with arrow function
87db94a 
PR-URL: #24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Amanpreet-03 @rvagg
test: replace anonymous closure functions with arrow function
b1dee7d 
PR-URL: #24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@Amanpreet-03 @codebytere
test: replace anonymous closure functions with arrow function
01532b8 
PR-URL: #24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Amanpreet-03 @refack
test: replace anonymous closure functions with arrow function
e3ee8e2 
PR-URL: nodejs#24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@Amanpreet-03 @codebytere
test: replace anonymous closure functions with arrow function
8f7326c 
PR-URL: #24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@trivikr trivikr trivikr approved these changes
+2 more reviewers
@targos targos targos approved these changes
@sagirk sagirk sagirk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Amanpreet-03 @targos @Trott @jasnell @cjihrig @sagirk @gireeshpunathil @trivikr @nodejs-github-bot