Repository navigation
Conversation
|
I'd like to see some discussion here about whether to |
Lots of red. I wonder if it's related to the ECONNRESET rework. |
|
@bnoordhuis Not sure, I picked a couple of the reds randomly and test-tls-hello-parser-failure.js fails. Related? |
|
Unblocks #2167 |
|
Doh, the upgrade does indeed break that test: I'll try to see what's going on. |
|
Well, f*ck. It's indeed the ECONNRESET stuff. The error here https://github.com/nodejs/io.js/blob/master/test/parallel/test-tls-hello-parser-failure.js#L35 is ECONNRESET without the uv upgrade. I guess what happens here is that the connection is closed because that's not a valid TLS handshake, discarding all that data and resulting in ECONNRESET, but we swallow it so it looks like the connection was properly closed. Hum. |
|
So we wait for 1.7.1? |
|
I had a look at the test and I think it's bogus. It's testing something that's more an accident of the implementation than actual specified behavior. I suggest this change: diff --git a/test/parallel/test-tls-hello-parser-failure.js b/test/parallel/test-tls-hello-parser-failure.js
index 3378583..7e3250d 100644
--- a/test/parallel/test-tls-hello-parser-failure.js
+++ b/test/parallel/test-tls-hello-parser-failure.js
@@ -26,22 +26,11 @@ var server = tls.createServer(options, function(c) {
client.write(bonkers);
});
- var once = false;
-
var writeAgain = setTimeout(function() {
client.write(bonkers);
});
- client.on('error', function(err) {
- if (!once) {
- clearTimeout(writeAgain);
- once = true;
- client.destroy();
- server.close();
- }
- });
-
- client.on('close', function(hadError) {
- assert.strictEqual(hadError, true, 'Client never errored');
- });
+ client.on('close', common.mustCall(function() {
+ server.close();
+ }));
}); |
|
@bnoordhuis hum, but shouldn't that test actually fail with ECONNRESET (ast it did)? My understanding is as follows, please do correct me if I'm wrong:
So, to the client it looks like the server closed the connection after reading all the data, but this didn't happen. My hunch is that we have to revert the ECONNRESET squelching patch, WDYT? |
That's right but it strongly depends on the data size. If the data fits in a single TCP packet, the connection is shut down with a FIN, not a RST. If you change the test to send 500 byte messages it won't ECONNRESET, so you can argue that the new behavior is more consistent than the old behavior. I agree that it's best to be conservative however, so let's revert for now. |
This reverts commit 05a003a. Refs: nodejs/node#2310 (comment)
|
@bnoordhuis Interesting, TIL! PR for the revert here: libuv/libuv#475 Once / if that lands I'll make a 1.7.1 release and update this PR. |
This reverts commit 05a003a. This commit triggerd "test-tls-hello-parser-failure" failure in io.js. See the reference below for a more thorough explanation. Refs: nodejs/node#2310 (comment)
This reverts commit 05a003a. This commit triggerd "test-tls-hello-parser-failure" failure in io.js. See the reference below for a more thorough explanation. Refs: nodejs/node#2310 PR-URL: libuv#475 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
The revert landed. Floated the patch, if all goes well I'll release 1.7.1. CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/230/ |
|
test-tls-server-verify fails on Windows, but it takes like a minute. Timeout? |
|
It's possible, it's been flaky before, but it is suspicious that it fails on both buildbots. Maybe run it one more time? BTW, https://jenkins-iojs.nodesource.com/job/node-test-pull-request is the new preferred target, it rebases onto the target branch before building. |
|
OK, running it (Windows only) here: https://jenkins-iojs.nodesource.com/job/iojs+pr+win/230/
Ph, didn't know, thanks! |
|
No luck: |
|
I took a look at this but I have no clue what could be causing the failure :-S Any help would be appreciated. |
|
cc @indutny or @bnoordhuis? |
|
I manually bisected it and found the culprit: 2dddd56, by yours trully. Oh well. I'll dig and see what I missed... |
|
libuv/libuv@2dddd56 ? Not a big change, hopefully easy to fix :) |
|
The freebsd and sunos failures are unrelated I think. This is new...?: https://jenkins-iojs.nodesource.com/job/node-test-commit-arm/291/nodes=armv7-wheezy/tapTestReport/test.tap-797/ |
|
Updated to 1.7.3, hopefully we're good now. CI: https://jenkins-iojs.nodesource.com/job/node-test-pull-request/195/ Sorry for the noise, everyone. |
|
@saghul so far failures seem unrelated. |
|
Would be nice if we could get this and #2167 in before v4. |
|
Rubber stamp LGTM. Is anything still holding this up? Are the CI failures all unrelated? Do we need another CI run? |
|
someone can try land with Jenkins node-accept-pull-request, flaky test ignores should figure it out |
|
The last CI run had few Windows failures and the changes corresponding to them were reverted immediately. Starting an accept-pull-request job now. |
PR-URL: #2310 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
|
Landed in a161594 |
|
@thefourtheye Thanks! 😻 |
|
\o/ |
|
@rvagg Can this go in 3.3.0? |
PR-URL: #2310 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Notable changes: * build: Add a --link-module option to configure that can be used to bundle additional JavaScript modules into a built binary (Bradley Meck) nodejs#2497 * docs: Merge outstanding doc updates from joyent/node (James M Snell) nodejs#2378 * http_parser: Significant performance improvement by having http.Server consume all initial data from its net.Socket and parsing directly without having to enter JavaScript. Any 'data' listeners on the net.Socket will result in the data being "unconsumed" into JavaScript, thereby undoing any performance gains. (Fedor Indutny) nodejs#2355 * libuv: Upgrade to 1.7.3 (from 1.6.1), see https://github.com/libuv/libuv/blob/v1.x/ChangeLog for details (Saúl Ibarra Corretgé) nodejs#2310 * V8: Upgrade to 4.4.63.30 (from 4.4.63.26) (Michaël Zasso) nodejs#2482
|
@thefourtheye it's in, testing and building at the same time now |
|
@rvagg Awesome :-) Thanks. |
Latest and greatest, fresh out of the oven!
R=@bnoordhuis
(Ben, I keep R-ing you, let me know if I should reference someone else as well :-))