Skip to content

test: add crypto check to test-http2-debug - #21205

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:test-http2-debug-withoutssl
Closed

danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:test-http2-debug-withoutssl

Conversation

@danbev

@danbev danbev commented Jun 8, 2018

Copy link
Copy Markdown
Contributor

This commit adds a crypto check to test-http2-debug.js as it currently
will error if configured --without-ssl.

The issue here is that the while the test spawns a child process that
runs test-http2-ping.js, which does have a crypto check, it will just
print 1..0 # Skipped: missing crypto to stdout, and nothing to stderr
which is what this test is trying to assert and hence failing.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This commit adds a crypto check to test-http2-debug.js as it currently
will error if configured --without-ssl.

The issue here is that the while the test spawns a child process that
runs test-http2-ping.js, which does have a crypto check, it will just
print '1..0 # Skipped: missing crypto' to stdout, and nothing to stderr
which is what this test is trying to assert and hence failing.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Jun 8, 2018
@danbev

ghost commented Jun 8, 2018

Copy link
Copy Markdown
Contributor Author

@danbev danbev added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jun 8, 2018
@danbev

ghost commented Jun 8, 2018

Copy link
Copy Markdown
Contributor Author
node-test-commit-smartos failure looks unrelated

console output:

01:31:26 WARNING: C++ compiler too old, need g++ 4.9.4 or clang++ 3.4.2 (CXX=g++)
01:31:26 ERROR: Did not find a new enough assembler, install one or build with
01:31:26        --openssl-no-asm.
01:31:26        Please refer to BUILDING.md
01:31:26 make: *** [Makefile:463: build-ci] Error 1
01:31:26 Build step 'Execute shell' marked build as failure
01:31:26 Checking ^not ok
01:31:27 Jenkins Text Finder: File set '*.tap' is empty
01:31:27 Performing Post build task...
01:31:27 Match found for : : True
01:31:27 Logical operation result is TRUE
01:31:27 Running script  : #/bin/bash
01:31:27 
01:31:27 set -x
01:31:27 mkdir out/junit
01:31:27 tap2junit -i test.tap -o out/junit/test.xml
01:31:27 tap2junit -i cctest.tap -o out/junit/cctest.xml
01:31:27 [smartos16-64] $ /bin/sh -xe /var/tmp/jenkins7423661485300701653.sh
01:31:27 + set -x
01:31:27 + mkdir out/junit
01:31:27 mkdir: cannot create directory 'out/junit': No such file or directory
01:31:27 POST BUILD TASK : FAILURE
01:31:27 END OF POST BUILD TASK : 0
01:31:27 Recording test results
01:31:27 ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error?
01:31:27 Notifying upstream projects of job completion
01:31:27 Finished: FAILURE

@danbev

ghost commented Jun 11, 2018

Copy link
Copy Markdown
Contributor Author

Landed in f86a181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants