Conversation
This commit adds a crypto check to test-http2-debug.js as it currently will error if configured --without-ssl. The issue here is that the while the test spawns a child process that runs test-http2-ping.js, which does have a crypto check, it will just print '1..0 # Skipped: missing crypto' to stdout, and nothing to stderr which is what this test is trying to assert and hence failing.
commented
Jun 8, 2018
Contributor
Author
commented
Jun 8, 2018
Contributor
Author
node-test-commit-smartos failure looks unrelated01:31:26 WARNING: C++ compiler too old, need g++ 4.9.4 or clang++ 3.4.2 (CXX=g++)
01:31:26 ERROR: Did not find a new enough assembler, install one or build with
01:31:26 --openssl-no-asm.
01:31:26 Please refer to BUILDING.md
01:31:26 make: *** [Makefile:463: build-ci] Error 1
01:31:26 Build step 'Execute shell' marked build as failure
01:31:26 Checking ^not ok
01:31:27 Jenkins Text Finder: File set '*.tap' is empty
01:31:27 Performing Post build task...
01:31:27 Match found for : : True
01:31:27 Logical operation result is TRUE
01:31:27 Running script : #/bin/bash
01:31:27
01:31:27 set -x
01:31:27 mkdir out/junit
01:31:27 tap2junit -i test.tap -o out/junit/test.xml
01:31:27 tap2junit -i cctest.tap -o out/junit/cctest.xml
01:31:27 [smartos16-64] $ /bin/sh -xe /var/tmp/jenkins7423661485300701653.sh
01:31:27 + set -x
01:31:27 + mkdir out/junit
01:31:27 mkdir: cannot create directory 'out/junit': No such file or directory
01:31:27 POST BUILD TASK : FAILURE
01:31:27 END OF POST BUILD TASK : 0
01:31:27 Recording test results
01:31:27 ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error?
01:31:27 Notifying upstream projects of job completion
01:31:27 Finished: FAILURE |
watilde
approved these changes
Jun 8, 2018
ryzokuken
approved these changes
Jun 8, 2018
hristijankiko
approved these changes
Jun 8, 2018
cjihrig
approved these changes
Jun 8, 2018
richardlau
approved these changes
Jun 9, 2018
jasnell
approved these changes
Jun 9, 2018
lpinca
approved these changes
Jun 9, 2018
commented
Jun 11, 2018
Contributor
Author
|
Landed in f86a181. |
Merged
This was referenced Jun 20, 2018
This was referenced Jun 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a crypto check to test-http2-debug.js as it currently
will error if configured
--without-ssl.The issue here is that the while the test spawns a child process that
runs
test-http2-ping.js, which does have a crypto check, it will justprint
1..0 # Skipped: missing cryptoto stdout, and nothing to stderrwhich is what this test is trying to assert and hence failing.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes