Repository navigation
Conversation
jasnell
approved these changes
Jan 29, 2018
apapirovski
approved these changes
Jan 31, 2018
6 tasks done
Member
Member
|
Looks like some linting issues. |
Contributor
Author
|
Oops, forgot to remove a |
Member
|
Landed in 71b15e8 |
Merged
Contributor
|
Should this be backported to |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
socketErroreventHttp2Session#close(as far as I could tell in the implementation,closeno longer accepts anoptionsobject)ClientHttp2Session'altsvc'eventHttp2SecureServerto be alphabetical and added'session'event (fromHttp2Server)Checklist
Affected core subsystem(s)
doc