Skip to content

docs: fix link for https api change - #17630

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:fix-link
Closed

docs: fix link for https api change#17630
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:fix-link

Conversation

@MylesBorins

Copy link
Copy Markdown
Contributor

The PR number included for this api addition was originally incorrect.

Refs: #14903

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. https Issues and PRs related to the https subsystem. labels Dec 12, 2017
The PR number included for this api addition was originally incorrect.

Refs: nodejs#14903
@vsemozhetbyt vsemozhetbyt added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Dec 12, 2017
@maclover7

Copy link
Copy Markdown
Contributor

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maclover7 maclover7 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 12, 2017
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Dec 12, 2017
The PR number included for this api addition was originally incorrect.

PR-URL: nodejs#17630
Refs: nodejs#14903
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR

Copy link
Copy Markdown
Member

Landed in dc92540

BTW: I fixed the subsystem to "doc" 😉

@BridgeAR BridgeAR closed this Dec 12, 2017
@addaleax addaleax removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 13, 2017
MylesBorins added a commit that referenced this pull request Jan 10, 2018
The PR number included for this api addition was originally incorrect.

PR-URL: #17630
Refs: #14903
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
MylesBorins added a commit that referenced this pull request Jan 10, 2018
The PR number included for this api addition was originally incorrect.

PR-URL: #17630
Refs: #14903
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. https Issues and PRs related to the https subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants