Skip to content

timers: use Number() on timeout/repeat values - #1597

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:perf-timers
Closed

timers: use Number() on timeout/repeat values#1597
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:perf-timers

Conversation

@mscdex

@mscdex mscdex commented May 3, 2015

Copy link
Copy Markdown
Contributor

This results in a ~14-23% performance increase in the 'breadth' timers benchmark.

Related jsperf

@mscdex mscdex added the timers Issues and PRs related to timers, setImmediate(), setInterval(), and setTimeout(). label May 3, 2015
@mscdex mscdex closed this May 3, 2015
@mscdex mscdex reopened this May 3, 2015
This results in a ~14-23% performance increase in the
'breadth' timers benchmark.
@mscdex mscdex changed the title timers: use parseInt on timeout/repeat values timers: use Number() on timeout/repeat values May 3, 2015
@mscdex mscdex closed this May 3, 2015
@mscdex
mscdex deleted the perf-timers branch May 3, 2015 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

timers Issues and PRs related to timers, setImmediate(), setInterval(), and setTimeout().

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant