Skip to content

doc: document repl on-demand loading#1249

Closed
silverwind wants to merge 1 commit intonodejs:v1.xfrom
silverwind:repl-auto-loading
Closed

doc: document repl on-demand loading#1249
silverwind wants to merge 1 commit intonodejs:v1.xfrom
silverwind:repl-auto-loading

Conversation

@silverwind
Copy link
Copy Markdown
Contributor

@silverwind silverwind commented Mar 24, 2015

Continuation of #1248. Related: #992.

@Fishrock123 : Updated, please check again

@silverwind silverwind added the doc Issues and PRs related to the documentations. label Mar 24, 2015
Fishrock123
Fishrock123 reviewed Mar 24, 2015
View reviewed changes
Comment thread doc/api/repl.markdown Outdated
Copy link
Copy Markdown
Contributor

@Fishrock123 Fishrock123 Mar 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just swap loaded and on-demand :)

Copy link
Copy Markdown
Contributor

@brendanashworth brendanashworth Mar 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "loaded on-demand" would sound better here. What do you think?

Copy link
Copy Markdown
Contributor Author

@silverwind silverwind Mar 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

Copy link
Copy Markdown
Contributor

@brendanashworth brendanashworth Mar 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, didn't even realize @Fishrock123 beat me to it :)

@Fishrock123
Copy link
Copy Markdown
Contributor

Fishrock123 commented Mar 24, 2015

LGTM with nit

@silverwind silverwind changed the title doc: document repl auto-loading doc: document repl on-demand loading Mar 24, 2015
@brendanashworth
Copy link
Copy Markdown
Contributor

brendanashworth commented Mar 24, 2015

LGTM too.

@silverwind silverwind self-assigned this Mar 24, 2015
silverwind added a commit that referenced this pull request Mar 24, 2015
@silverwind
doc: document repl on-demand module loading
e84dd5f 
Fixes: #992
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
PR-URL: #1249
@silverwind
Copy link
Copy Markdown
Contributor Author

silverwind commented Mar 24, 2015

merged in e84dd5f

@silverwind silverwind closed this Mar 24, 2015
@rvagg rvagg mentioned this pull request Mar 25, 2015
Closed
@Fishrock123 Fishrock123 mentioned this pull request Apr 9, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@silverwind silverwind

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@silverwind @Fishrock123 @brendanashworth