crypto: Add crypto.getEngines() - #10865
Closed
shigeki wants to merge 1 commit into
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new api to show the list of loaded engines of OpenSSL.
It also includes the test of dynamic engine for
crypto.setEngine()and fixes missed test coverages as discussed in #10786.A test engine is built from
test/fixtures/openssl_test_engine/by adding a new target in node.gyp, but fipsld seems to have an error with linking the test engine withlibcrypto.aso that a dynamic engine test is skipped in FIPS mode.I've already made several CI tests and found that tests on Windows and arm were failed because test engine files were lost in CI environment. They can be solved by including
Release\node_test_engine.dllin Windows tests andout/Release/libnode_test_engine.soin arm tests inbinary/binary.tar.gzandbinary/binary.tar.xz. I would like ask someone in @nodejs/build to help it.In my local environments, tests in Win and arm are fine.
CC @nodejs/crypto and @jasnell
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
crypto