Skip to content

AIX: Intermittent failure on pseudo-tty/test-tty-wrap #9728

Closed
#28129
Closed
AIX: Intermittent failure on pseudo-tty/test-tty-wrap#9728
#28129
Labels
aixIssues and PRs related to the AIX platform.flaky-testIssues and PRs involving tests that fail intermittently in CI.ttyIssues and PRs related to the tty subsystem.

Description

@mhdawson
mhdawson
opened on Nov 21, 2016
  • Version: master and 4.x
  • Platform: AIX
  • Subsystem: pseudo-tty

Seen a few intermittent failures in the pseudo-tty/test-tty-wrap test today

https://ci.nodejs.org/job/node-test-commit-aix/1998/nodes=aix61-ppc64/
https://ci.nodejs.org/job/node-test-commit-aix/1988/nodes=aix61-ppc64/

length differs.
expect=2
actual=0
patterns:
pattern = ^hello\ world\ 1$
pattern = ^hello\ world\ 2$
outlines:
not ok 1242 pseudo-tty/test-tty-wrap
  ---
  duration_ms: 0.150
  severity: fail
  stack: |-
  ...

Activity

  1. mhdawson commented on Nov 21, 2016

    @mhdawson
    mhdawson
    on Nov 21, 2016
    MemberAuthor

    stress run - https://ci.nodejs.org/job/node-stress-single-test/nodes=aix61-ppc64/1067/

  2. mhdawson
    changed the title [-]AIX: Intermittent failure on [/-] [+]AIX: Intermittent failure on pseudo-tty/test-tty-wrap[/+] on Nov 21, 2016
  3. mscdex
    added
    aixIssues and PRs related to the AIX platform.
    on Nov 21, 2016

  4. Trott commented on Nov 21, 2016

    @Trott
    Trott
    on Nov 21, 2016
    Member

    /cc @Fishrock123

  5. Trott
    added
    ttyIssues and PRs related to the tty subsystem.
    on Nov 21, 2016

  6. Fishrock123 commented on Nov 21, 2016

    @Fishrock123
    Fishrock123
    on Nov 21, 2016
    Contributor

    I am very confused. What? How?

  7. Fishrock123 commented on Nov 21, 2016

    @Fishrock123
    Fishrock123
    on Nov 21, 2016
    Contributor

    Oh I see, no output is produced? Oh dear.

    I guess you've triggered the exit bug with load alone?? ¯\_(ツ)_/¯

  8. gibfahn commented on Nov 22, 2016

    @gibfahn
    gibfahn
    on Nov 22, 2016
    Member

    cc/ @nodejs/platform-aix @Akpotohwo

  9. mhdawson commented on Nov 22, 2016

    @mhdawson
    mhdawson
    on Nov 22, 2016
    MemberAuthor

    Passed 200 runs in stress build.

  10. Akpotohwo commented on Nov 25, 2016

    @Akpotohwo
    Akpotohwo
    on Nov 25, 2016

    Failed 24 times in 3100 on one of our aix machines... It's the same failure as shown earlier.

  11. mhdawson commented on Nov 25, 2016

    @mhdawson
    mhdawson
    on Nov 25, 2016
    MemberAuthor

    Good to hear you can recreate.

  12. mhdawson commented on Dec 8, 2016

    @mhdawson
    mhdawson
    on Dec 8, 2016
    MemberAuthor

    Failed again in the build today. https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/2433/

    @Akpotohwo any update on the investigation ?

  13. mhdawson commented on Dec 15, 2016

    @mhdawson
    mhdawson
    on Dec 15, 2016
    MemberAuthor

    Failed again https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/2566/console

  14. Trott commented on Dec 23, 2016

    @Trott
    Trott
    on Dec 23, 2016
    Member

    Again today:

    https://ci.nodejs.org/job/node-test-commit-aix/2736/nodes=aix61-ppc64/console:

    length differs.
expect=2
actual=0
patterns:
pattern = ^hello\ world\ 1$
pattern = ^hello\ world\ 2$
outlines:
not ok 1288 pseudo-tty/test-tty-wrap
  ---
  duration_ms: 0.158
  severity: fail
  stack: |-

  15. Trott commented on Dec 23, 2016

    @Trott
    Trott
    on Dec 23, 2016
    Member

    I guess you've triggered the exit bug with load alone?? ¯_(ツ)_/¯

    @Fishrock123 (or anyone else that knows): Can you elaborate a bit on "the exit bug"? Is there a link or something?

  16. 18 remaining items

  17. gibfahn commented on Mar 2, 2017

    @gibfahn
    gibfahn
    on Mar 2, 2017
    Member

    I'm still +1 on adding a delay, it seems like a vastly simpler option.

  18. MylesBorins
    added 2 commits that reference this issue on Mar 7, 2017

    test: mark test-tty-wrap as flaky for AIX

    bbb6c69

    test: mark test-tty-wrap as flaky for AIX

    2c4aa39

  19. gibfahn commented on Mar 30, 2017

    @gibfahn
    gibfahn
    on Mar 30, 2017
    Member

    @gireeshpunathil so to clarify, would adding a delay fix the issue for pseudo-tty/test-tty-wrap, or do we need to get the underlying Python bug fixed first?

  20. gireeshpunathil commented on Mar 30, 2017

    @gireeshpunathil
    gireeshpunathil
    on Mar 30, 2017
    Member

    @gibfahn - as per clarified here - this issue is root caused by the python bug in question, and cannot be circumvented through time delay. The python parent gets trapped in the system on an fd close call, without recovery

  21. Trott commented on Jul 31, 2017

    @Trott
    Trott
    on Jul 31, 2017
    Member

    This hasn't recurred in some time. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree, but I'm inclined to close at this time. I'm just tidying up and not acting on a super-strong opinion or anything like that.

  22. Trott
    closed this as completedon Jul 31, 2017
  23. sam-github
    reopened this on Jun 7, 2019

  24. sam-github commented on Jun 7, 2019

    @sam-github
    sam-github
    on Jun 7, 2019
    Contributor

    This is still referenced in

    node/test/pseudo-tty/pseudo-tty.status

    Line 4 in 6447be6

    # being investigated under https://github.com/nodejs/node/issues/9728

    If we close it, shouldn't we also remove the reference to it? Or perhaps change the ref to nodejs/build#1820?

    Or perhaps, I misunderstand the meaning of test-tty-wrap : FAIL, PASS? That seems to imply the test is considered sucessful if it passes or if it fails, which seems to cover all the options, and not be so useful.

  25. sam-github
    added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Jun 7, 2019

  26. Trott commented on Jun 8, 2019

    @Trott
    Trott
    on Jun 8, 2019
    Member

    @sam-github Yes, you are correct: That entry should be removed. #28129

  27. Trott
    added a commit that references this issue on Jun 10, 2019

    test: remove test-tty-wrap from status file

    d7f60b7
  28. Trott
    closed this as completedin #28129on Jun 10, 2019
  29. BridgeAR
    added a commit that references this issue on Jun 17, 2019

    test: remove test-tty-wrap from status file

    d6791d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    aixIssues and PRs related to the AIX platform.flaky-testIssues and PRs involving tests that fail intermittently in CI.ttyIssues and PRs related to the tty subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions