Skip to content

doc: update collaborator_guide to mention core-validate-commit #9328

Closed
Closed
doc: update collaborator_guide to mention core-validate-commit#9328
Labels
docIssues and PRs related to Node.js documentation.metaIssues and PRs related to the general management of the project.

Description

@srl295
srl295
opened on Oct 27, 2016

Subsystem: doc

…should mention @evanlucas ' https://github.com/evanlucas/core-validate-commit as a helpful tool in validating commit messages.

It could be helpful even for contributors also.

Activity

  1. srl295 commented on Oct 27, 2016

    @srl295
    srl295
    on Oct 27, 2016
    MemberAuthor

    not unrelated: nodejs/core-validate-commit#13

  2. Trott commented on Oct 27, 2016

    @Trott
    Trott
    on Oct 27, 2016
    Member

    doc/onboarding.md too

  3. mscdex
    added
    docIssues and PRs related to Node.js documentation.
    metaIssues and PRs related to the general management of the project.
    on Oct 27, 2016

  4. tanujasawant commented on Oct 29, 2016

    @tanujasawant
    tanujasawant
    on Oct 29, 2016
    Contributor

    @mscdex I'd like to work on this issue. I'm a newbie in Open Source, should I know anything before I get started?
    Thanks! :)

  5. sam-github commented on Oct 31, 2016

    @sam-github
    sam-github
    on Oct 31, 2016
    Contributor

    @Tanuja-Sawant read https://github.com/nodejs/node/blob/master/CONTRIBUTING.md and give it a go, thanks!

  6. tanujasawant commented on Nov 1, 2016

    @tanujasawant
    tanujasawant
    on Nov 1, 2016
    Contributor

    Okay, thanks @sam-github
    Can you tell me where do I make changes that will eventually modify https://nodejs.org/en/get-involved/development/#landing-pull-requests
    Thanks! :)

  7. gibfahn commented on Nov 1, 2016

    @gibfahn
    gibfahn
    on Nov 1, 2016
    Member

    @Tanuja-Sawant You want the nodejs.org repo, that section is: https://github.com/nodejs/nodejs.org/blob/c8baa35c5b752fa7151da4ea22fab0b493f6a997/locale/en/get-involved/development.md#landing-pull-requests

    It looks like that page is pretty similar to some of the stuff in https://github.com/nodejs/node/blob/add885416f38020f84b544b3cc0be28d6cf59bdc/COLLABORATOR_GUIDE.md#landing-pull-requests , they may well have got out of sync and need updating.

  8. tanujasawant commented on Nov 1, 2016

    @tanujasawant
    tanujasawant
    on Nov 1, 2016
    Contributor

    @gibfahn Oh I just saw your comment after creating a PR for other doc files. The page you referred me to is included in the code of nodejs/nodejs.org directory. Will it be apt to make changes of that file and make a PR here -in nodejs/node?
    Thanks so much!

  9. gibfahn commented on Nov 1, 2016

    @gibfahn
    gibfahn
    on Nov 1, 2016
    Member

    @Tanuja-Sawant You'll need to fork nodejs/nodejs.org and open a separate PR for changes to that Github repo, unfortunately Github needs 1 PR per repo.

    So you'll end up with two Pull Requests, I'd include a link to the other Pull Request and to this issue in each Pull Request.

  10. fhemberger
    added a commit that references this issue on Nov 2, 2016

    locale: update development.md (#1003)

    762fef1
  11. Fishrock123
    closed this as completedin 762fef1on Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to Node.js documentation.metaIssues and PRs related to the general management of the project.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions