Repository navigation
child_process: outdated comment #8927
Description
Activity
I'm Tanuja Sawant and would like to work on this issue as part of one of my initial contributions to Node.js for the Outreachy Internship. Would you kindly assign this issue to me or should I go ahead and make a pull request?
Thanks so much!Reacted by F. HinkelmannHi again!
Please correct me if I'm wrong, the comment// Leave stdin open for the IPC channel. stdout and stderr should be the // same as the parent's if silent isn't set.can be replaced by
// Use a separate fd=4 for IPC channel. Inherit stdin, stdout and stderr // from the parent if silent isn't set.@Tanuja-Sawant Can you open a pull request? Collaborators will review it and suggest changes if necessary.
Reacted by tanujasawantpulled request in #8988
Reacted by James M Snell
There is an outdated comment in lib/child_process.js that needs to be updated to better reflect what the code beneath it has been doing for some time now. Instead of commandeering stdin for IPC usage, a separate fd is actually used for IPC.