Skip to content

Proposal: Introduce CI builds to GitHub PR process #84

Description

@imjacobclark

We should be introducing CI builds to the GitHub PR process to verify code integrity, tests and coverage for those contributing to the codebase.

There are plenty out there, Travis-CI, Drone, Hosted Jenkins.

Thoughts?

Activity

  1. Fishrock123 commented on Dec 5, 2014

    @Fishrock123
    Contributor

    @rvagg has been working on the io.js CI - see https://github.com/iojs/build

    I'm pretty sure it was supposed to be enabled here but it doesn't seem to be?

  2. rvagg commented on Dec 6, 2014

    @rvagg
    Member

    We're getting there, it's just not a trivial process, it's the next big thing on my list of things to do and I'll be spending some time this month on making it happen.

    Currently a limited set of people can trigger builds for any PR and I'm happy to expand that list to include any other people with commit access to io.js if they want to help test incomings.

    Another problem we have is that the test suite isn't quite solid enough yet and will result in a lot of false positives, we've been working on that and it's something that will improve over time as we start to get frustrated with them.

  3. jbergstroem commented on Dec 6, 2014

    @jbergstroem
    Member

    Additionally, it'd be great to get the build status on the branch page as well (especially if branches become part of the workflow).

  4. chrisdickinson commented on Jan 18, 2015

    @chrisdickinson
    Contributor

    This is being tracked in an issue on iojs/build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions