Skip to content

Auto chmod/unlink when listening to domain socket #724

Closed
Closed
Auto chmod/unlink when listening to domain socket#724
Labels
netIssues and PRs related to the net subsystem.

Description

@kyriosli
kyriosli
opened on Feb 5, 2015

When using domain socket in net or http.createServer, I have to unlink it before service started and sometimes chmod to '777' after service started. Is it necessary to add option keys such as autoUnlink and chmod that do those jobs automatically?

require('net').createServer().listen({
  "path": "/var/run/app.sock",
  "autoUnlink": true, // boolean, default: false
  "chmod": "777" // string | number ( 0777 or, 0o777)
})

Activity

  1. vkurchatkin
    added
    netIssues and PRs related to the net subsystem.
    on Feb 5, 2015

  2. bnoordhuis commented on Feb 5, 2015

    @bnoordhuis
    bnoordhuis
    on Feb 5, 2015
    Member

    The reason neither options are supported right now is because of race conditions:

    • With chmod, there is a race window between the call to bind() and chmod().
    • With unlink(), the problem is that the socket may be shared with other processes and there is no 100% foolproof method of detecting whether it's safe to unlink (i.e. whether this process is the last process.)

    Auto-unlink used to be the default but was removed because of issues with the cluster module.

  3. cjihrig commented on Feb 15, 2015

    @cjihrig
    cjihrig
    on Feb 15, 2015
    Contributor

    Looks like this should be closed as won't fix.

  4. cjihrig
    closed this as completedon Feb 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    netIssues and PRs related to the net subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions