Skip to content

zlib: there are constants documented that don't exist #7204

Description

@jasnell

In the zlib docs, there are a handful of constants listed that do not exist in the actual code:

Specifically:

  • zlib.Z_BINARY
  • zlib.Z_TEXT
  • zlib.Z_ASCII
  • zlib.Z_UNKNOWN

See: https://nodejs.org/dist/latest-v6.x/docs/api/zlib.html#zlib_constants

Removed in: #7203

Activity

  1. added
    docIssues and PRs related to Node.js documentation.
    zlibIssues and PRs related to the zlib module and its compression dependencies.
    on Jun 7, 2016
  2. tarungarg546 commented on Jun 27, 2016

    @tarungarg546
    Contributor

    We would just need to remove these from docs right?

  3. fhinkel commented on Jul 2, 2016

    @fhinkel
    Contributor

    It seems like the .md file is already up-to-date. Are the HTML files not updated automatically?

  4. Fishrock123 commented on Jul 2, 2016

    @Fishrock123
    Contributor

    Ah that sounds right. The constants refactor commits have not yet made it into a release.

    However, those commits are marked as semver-major (via a label) and will not land in v6: #7203, but the "head: docs come from v6 currently.

    @fhinkel Could you check the v6.x branch, and if they are still there but not in the code, open a PR against that branch? :D

  5. added a commit that references this issue on Jul 9, 2016
  6. removed
    good first issueIssues that are suitable for first-time contributors.
    on Jul 10, 2016
  7. Fishrock123 commented on Jul 15, 2016

    @Fishrock123
    Contributor

    Fixed in e13ee29

  8. added a commit that references this issue on Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to Node.js documentation.zlibIssues and PRs related to the zlib module and its compression dependencies.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions