Repository navigation
sqlite: prevent reentrant statement finalization from callbacks #64795
Description
Version
main
Platform
macOS 26.5.2
Subsystem
sqlite
What steps will reproduce the bug?
import { DatabaseSync } from 'node:sqlite';
const db = new DatabaseSync(':memory:');
db.function('close_database', () => {
console.log('callback: closing database');
db.close();
console.log('callback: database closed');
});
console.log('before query');
db.prepare('SELECT close_database()').get();
console.log('after query');How often does it reproduce? Is there a required condition?
Always
What is the expected behavior? Why is that the expected behavior?
close() should reject or defer finalization while statement execution depth is non-zero; db.deserialize() should apply the same protection.
What do you see instead?
before query
callback: closing database
callback: database closed
Segmentation faultdb.close() finalizes the prepared statement while that same statement is executing inside sqlite3_step(), and the process subsequently crashes.
Additional information
No response
Activity
trivikr commentedon Aug 8, 2026
The reentrant StatementSync finalization from callbacks also needs to be fixed
Repro
Run either variant
Observed
Finalizing the currently executing statement through
close()orSymbol.disposecauses a segmentation faultExpected
The operation should throw
ERR_INVALID_STATEwhile that statement is executing.Additional Context
Noticed in #64796 (comment)
sqlite: reject deserialize() while in a callback
trivikr commentedon Aug 9, 2026
Closing as:
database.close()reject in callback was done in sqlite: prevent database close during callbacks #64743database.deserialize()reject in callback was done in sqlite: reject deserialize() while in a callback #64796sqlite: reject deserialize() while in a callback
sqlite: reject deserialize() while in a callback
sqlite: reject deserialize() while in a callback