Repository navigation
Invalid string construction #57133
Description
Activity
Correct. Contributions are welcome.
Reacted by Patrick Johnston and Ali Nour Al DinWould the change be like this
- return ThrowInvalidURL(realm->env(), input.ToStringView(), nullptr); + return ThrowInvalidURL(realm->env(), input.ToStringView(), std::nullopt);
If so, could this issue be a
good first issue?Reacted by Yagiz NizipliHey, I'd like to take this on.
Reacted by Edy SilvaCan, I take this one if there is no objection?
Hey @Ali-Adel-Nour, there is an open PR addressing this issue already (#57141).
Reacted by Ali Nour Al Din
node/src/node_url.cc
Line 164 in a724a9e
ThrowInvalidURLtakes anstd::optional<std::string>as third parameter. Passingnullptrconstructs astd::stringfrom that null pointer, this is undefined behaviour (upgraded to ill-formed in C++23). At a glance, it would seem thatstd::nulloptwas the intended third argument.