Skip to content

eslint hangs on /bechmark #5669

Closed
Closed
eslint hangs on /bechmark#5669
Labels
benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.duplicateIssues and PRs that are duplicates of other issues or PRs.toolsIssues and PRs related to the tools directory.

Description

@vkurchatkin
vkurchatkin
opened on Mar 11, 2016

Eslint hangs indefinitely if /benchmark folder is included. Simplest way to reproduce: ./node tools/eslint/bin/eslint.js benchmark --rulesdir tools/eslint-rules

  • Platform: OS X 10.10.5

/cc @Trott

Activity

  1. vkurchatkin
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    macosIssues and PRs related to the macOS platform.
    on Mar 11, 2016

  2. mscdex commented on Mar 11, 2016

    @mscdex
    mscdex
    on Mar 11, 2016
    Contributor

    Did you run the module-loader benchmark previously (e.g. is there a benchmark/tmp directory)?

  3. vkurchatkin commented on Mar 11, 2016

    @vkurchatkin
    vkurchatkin
    on Mar 11, 2016
    ContributorAuthor

    Never mind, I had 50000 of folders starting with nodejs-benchmark-module in benchmark/tmp/.

  4. mscdex
    added
    benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.
    toolsIssues and PRs related to the tools directory.
    and removed
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Mar 11, 2016

  5. vkurchatkin commented on Mar 11, 2016

    @vkurchatkin
    vkurchatkin
    on Mar 11, 2016
    ContributorAuthor

    @mscdex Yep. Probably is should be ignored by eslint

  6. mscdex commented on Mar 11, 2016

    @mscdex
    mscdex
    on Mar 11, 2016
    Contributor

    I ran into the same problem, see #5595 and #5638.

  7. vkurchatkin
    closed this as completedon Mar 11, 2016
  8. vkurchatkin
    added
    duplicateIssues and PRs that are duplicates of other issues or PRs.
    on Mar 11, 2016
  9. mscdex
    removed
    macosIssues and PRs related to the macOS platform.
    on Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.duplicateIssues and PRs that are duplicates of other issues or PRs.toolsIssues and PRs related to the tools directory.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions