Data URLs can't have query params

[avivkeller]

Version

main

Platform

N/A

Subsystem

No response

What steps will reproduce the bug?

await import("data:text/javascript,console.log(import.meta.url)?query")

How often does it reproduce? Is there a required condition?

Everytime

What is the expected behavior? Why is that the expected behavior?

The Data URL should load correctly, printing the import.meta.url with the query

What do you see instead?

SyntaxError: Unexpected end of input

Additional information

I believe this is due to #54748 (CC @KhafraDev)

[KhafraDev]

The parser is correct here. It doesn't work in Chrome or Firefox nor could I find anywhere in the spec that says to treat query params separately from the body.

If I'm wrong please correct me.

Treating query params separately creates a myriad of issues that moving to a dedicated parser aimed to fix; should the question mark in data:text/javascript;console.log('?') be treated as a query param?

[avivkeller]

Shouldn't that PR become semver-major, as it modifies the existing behavior?

[KhafraDev]

I'd consider it a bug fix so not a semver-major change, we've done this a few times in undici. @nodejs/web-standards

[aduh95]

Someone reported the old behavior as a bug: #53775

It's always tricky to decide whether any change qualifies as a bug fix or as a breaking change (cf XKCD 1172). Do you have a use case for having a query parameter?

[avivkeller]

Do you have a use case for having a query parameter?

Not really, I just noticed that this behavior was different in the main branch than the latest release when preparing #54933, and I figured it should be a non-patch change when sent to release lines.

[aduh95]

IMO we should treat it as a bug fix (i.e. semver-patch): if there’s no use case for it, then it’s not going to break anyone — and it’s going to unbreak a few folks