flaky: parallel.test-child-process-fork-net #51813

Activity

1. mhdawson

   added

   flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.

   on Feb 20, 2024
2. github-actions

   added

   windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.

   on Feb 20, 2024
3. joyeecheung commented on Feb 22, 2024

   

   joyeecheung

   on Feb 22, 2024

   Member

   More actions

   This has failed 14 PRs out of the last 100 CI runs.

   From a glance the test it's hard to tell what it is trying to do. It was added by dceebbf#diff-53a1141f9d431cc7d603359ba604d660819f5560b68895fb639dc988a34644c8 so I suppose the original intention was just to test that the socket can be sent over to the child. The messages based on connection order seems to be very brittle, I don't think we guarantee that if you fork multiple child processes, they are going to be ready to connect to the parent in the exact same order that you start them. Perhaps the test can be split so that each child process gets its own test. But that's just a guess, I am not 100% that's not breaking what the test was trying to check.
4. joyeecheung commented on Feb 23, 2024

   

   joyeecheung

   on Feb 23, 2024

   Last edited by joyeecheung

   Member

   More actions

   Actually I have a different theory. See #51841
5. joyeecheung

   added a commit that references this issue on Feb 25, 2024

   test: fix test-child-process-fork-net

   ...

   ec7a268
6. lpinca commented on Sep 7, 2024

   

   lpinca

   on Sep 7, 2024

   Member

   More actions

   Fixed in #51841.
7. lpinca

   closed this as completedon Sep 7, 2024