Impossible to build with vs2022

[PaTiToMaSteR]

Version

19.4.0 and 19.4.3

Platform

Microsoft Windows NT 10.0.22621.0 x64

Subsystem

No response

What steps will reproduce the bug?

.\vcbuild release vs2022 x64

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Have no errors

What do you see instead?

  libnode.vcxproj -> out\Release\lib\libnode.lib
  v8_base_without_compiler.vcxproj -> ..\..\out\Release\lib\v8_base_without_compiler.lib
  v8_initializers.vcxproj -> ..\..\out\Release\lib\v8_initializers.lib
     Creating library ..\..\out\Release\mksnapshot.lib and object ..\..\out\Release\mksnapshot.exp
mksnapshot.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object __cdecl v8::internal::Fixed
Array::get(int)const " (?get@FixedArray@internal@v8@@QEBA?AVObject@23@H@Z) [C:\Git\node-19.4.0\tools\v8_gypfiles\mksnapsho
t.vcxproj]
platform-embedded-file-writer-aix.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object __cd
ecl v8::internal::FixedArray::get(int)const " (?get@FixedArray@internal@v8@@QEBA?AVObject@23@H@Z) [C:\Git\node-19.4.0\tool
s\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-generic.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object
__cdecl v8::internal::FixedArray::get(int)const " (?get@FixedArray@internal@v8@@QEBA?AVObject@23@H@Z) [C:\Git\node-19.4.0\
tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-mac.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object __cd
ecl v8::internal::FixedArray::get(int)const " (?get@FixedArray@internal@v8@@QEBA?AVObject@23@H@Z) [C:\Git\node-19.4.0\tool
s\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-win.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object __cd
ecl v8::internal::FixedArray::get(int)const " (?get@FixedArray@internal@v8@@QEBA?AVObject@23@H@Z) [C:\Git\node-19.4.0\tool
s\v8_gypfiles\mksnapshot.vcxproj]
..\..\out\Release\mksnapshot.exe : fatal error LNK1120: 1 unresolved externals [C:\Git\node-19.4.0\tools\v8_gypfiles\mksna
pshot.vcxproj]

Additional information

It's only possible to build with vs2019, I tried some alternatives in other issues posts with no luck I'm afraid.

[PaTiToMaSteR]

Just as a note aside .\vcbuild debug vs2022 x64 works, not release

[bnoordhuis]

Possibly already fixed by (not yet released) commit nodejs/node-v8@691f1c4.

[StefanStojanovic]

There are also 2 opened PRs that address this issue #46228 and #46231

[StefanStojanovic]

#46228 landed, building with VS 2022 should work now.

[bnoordhuis]

Nice. I'll go ahead and close this then.