Repository navigation
Windows build break: Failed to generate license.rtf #43213
Description
Version
nightly
Platform
Windows
Subsystem
No response
What steps will reproduce the bug?
Windows CI builds are failing.
How often does it reproduce? Is there a required condition?
Today's daily master build and a number of CI's for pull requests.
What is the expected behavior?
Build completes.
What do you see instead?
Build fails. e.g. https://ci.nodejs.org/job/node-compile-windows/45207/nodes=win-vs2019/console
08:23:37 )
08:23:37 tools\license2rtf.mjs 0<LICENSE 1>Release\license.rtf
08:23:37 ) else (Release\node.exe tools\license2rtf.mjs 0<LICENSE 1>Release\license.rtf )
08:23:37
08:23:37 > if errorlevel 1 echo Failed to generate license.rtf & goto exit
08:23:37 Failed to generate license.rtf
08:23:37
08:23:37 > if 13 NEQ 0 exit /b 13
08:23:37
08:23:37 > if errorlevel 1 exit /b
08:23:37
08:23:37 > if errorlevel 1 exit /b
08:23:37
08:23:37 > if errorlevel 1 exit /b
08:23:37
08:23:37 > if errorlevel 1 exit /b
08:23:37 Build step 'Execute Windows batch command' marked build as failure
Additional information
#43101 landed yesterday and looks very relevant. That passed its CI but maybe something else has landed that when combined causes the break?
cc @nodejs/platform-win
Activity
richardlau commentedon May 26, 2022
Actually scratch that, the last CI for that PR was broken: https://ci.nodejs.org/job/node-test-pull-request/44161/. I'll open a revert.
richardlau commentedon May 26, 2022
Revert PR: #43214
Revert "tools: refactor `tools/license2rtf` to ESM"
F3n67u commentedon May 28, 2022
@richardlau do you have any idea why the windows build failed? I am not familiar with Nodejs Jenkins pipeline and windows stuff.
richardlau commentedon May 28, 2022
No I do not. There wasn't any further error messages to indicate why.
F3n67u commentedon May 29, 2022
@richardlau I found the reason why #43101 will cause windows build break. I made a pr: #43232, please take a look.
Revert "tools: refactor `tools/license2rtf` to ESM"
tools: refactor `tools/license2rtf` to ESM
tools: refactor `tools/license2rtf` to ESM
tools: refactor `tools/license2rtf` to ESM
tools: refactor `tools/license2rtf` to ESM
tools: refactor `tools/license2rtf` to ESM