You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Don't know if you have heard of this new URLPattern
Deno shipped it, and browser supports it, would be a cool util to have globally avalible to pear up with web standards and for usage in express routing for instance
Thanks for the heads up — obviously our feature request template is not very well-suited for these kinds of issues, but given that the specification for URLPattern is still in draft, I imagine that we would be setting the Webcompat Priority value of this to either ? or revisit if we were to use a triage system similar to what Mozilla uses for their WebCompat Tracking and Triage workflow.
Mainly being a volunteer-run organization, we have no real priorities (whatever gets done, gets done); that being said, this issue cannot be represented by one of the N values in that system…
I would say to perhaps set it as revisit and come back later once spec becomes a recommendation.
Deno shipped it, and browser supports it, would be a cool util to have globally avalible to pear up with web standards and for usage in express routing for instance
So I opened the original issue for support in Deno, I opened it on Deno as Deno tends to support considerably more cutting edge things.
Having said this, having it Node would be particularly valuable for libraries that are currently using path-to-regexp for patterns. The syntax is essentially the same (aside from a few bug fixes to work with URLs more generally), so libraries that are currently using path-to-regexp could use the builtin URLPattern instead, allowing them to remove a external dependency.
And having a common pattern syntax for things like routing would just generally be nice to have, so that libraries don't have a bunch of different microsyntaxes for essentially the same thing.
@targos ... I'm +1 on an having an implementation in core. I have some concerns about the performance as spec'd but having an implementation makes sense.
Reacted by Guy Bedford, dnalborczyk, Gabriel, Paweł Sieniarski, Yahor Siarheyenka and C. T. Lin
There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.
There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.
I've noticed that several people are posting "+1" on this issue thread. While I understand that this is meant to indicate support for the issue, it's actually causing a lot of unnecessary notifications for everyone who is subscribed to this thread. Additionally, posting "+1" does not add any meaningful contribution to the conversation and only make scrolling through the page more annoying in order to find the most meaningful comments.
Instead of posting a comment with "+1", I suggest that you simply use the "subscribe" button at the top of the issue thread to receive updates. Additionally, if you want to show support, you can use the "thumbs up" reaction on the original post. This will help keep the thread clean and reduce notifications for everyone.
I appreciate your interest in this issue, but please keep in mind that posting "+1" repeatedly can become frustrating and annoying to those who are subscribed. By using the subscribe button and reactions, we can keep the conversation focused and productive.
I don't want to have to unsubscribe to this topic if more ppl are going to post +1
Activity
DerekNonGeneric commentedon Nov 18, 2021
Thanks for the heads up — obviously our feature request template is not very well-suited for these kinds of issues, but given that the specification for
URLPatternis still in draft, I imagine that we would be setting the Webcompat Priority value of this to either?orrevisitif we were to use a triage system similar to what Mozilla uses for their WebCompat Tracking and Triage workflow.Mainly being a volunteer-run organization, we have no real priorities (whatever gets done, gets done); that being said, this issue cannot be represented by one of the N values in that system…
I would say to perhaps set it as
revisitand come back later once spec becomes a recommendation.[-]impl URLPattern[/-][+]implement URLPattern[/+]targos commentedon Nov 21, 2021
Spec is at https://github.com/WICG/urlpattern
WPT: https://github.com/web-platform-tests/wpt/tree/master/urlpattern
targos commentedon Nov 21, 2021
@nodejs/url what do you think?
Jamesernator commentedon Nov 23, 2021
So I opened the original issue for support in Deno, I opened it on Deno as Deno tends to support considerably more cutting edge things.
Having said this, having it Node would be particularly valuable for libraries that are currently using
path-to-regexpfor patterns. The syntax is essentially the same (aside from a few bug fixes to work with URLs more generally), so libraries that are currently usingpath-to-regexpcould use the builtinURLPatterninstead, allowing them to remove a external dependency.And having a common pattern syntax for things like routing would just generally be nice to have, so that libraries don't have a bunch of different microsyntaxes for essentially the same thing.
jasnell commentedon Nov 23, 2021
@targos ... I'm +1 on an having an implementation in core. I have some concerns about the performance as spec'd but having an implementation makes sense.
github-actions commentedon Aug 25, 2022
There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.
github-actions commentedon Sep 24, 2022
There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.
For more information on how the project manages feature requests, please consult the feature request management document.
7 remaining items
mharis commentedon Mar 30, 2023
+1
bj-nostra commentedon Apr 4, 2023
+1
jimmywarting commentedon Apr 4, 2023
Stop posting +1
Hello everyone,
I've noticed that several people are posting "+1" on this issue thread. While I understand that this is meant to indicate support for the issue, it's actually causing a lot of unnecessary notifications for everyone who is subscribed to this thread. Additionally, posting "+1" does not add any meaningful contribution to the conversation and only make scrolling through the page more annoying in order to find the most meaningful comments.
Instead of posting a comment with "+1", I suggest that you simply use the "subscribe" button at the top of the issue thread to receive updates. Additionally, if you want to show support, you can use the "thumbs up" reaction on the original post. This will help keep the thread clean and reduce notifications for everyone.
I appreciate your interest in this issue, but please keep in mind that posting "+1" repeatedly can become frustrating and annoying to those who are subscribed. By using the subscribe button and reactions, we can keep the conversation focused and productive.
I don't want to have to unsubscribe to this topic if more ppl are going to post +1
Thank you for your understanding and cooperation.
anonrig commentedon Apr 4, 2023
I've locked and limited the issue to collaborators.
anonrig commentedon May 9, 2023
anonrig commentedon Dec 12, 2024
I'm almost done with the implementation. I'll try to open a pull-request to Node.js by the end of this year: ada-url/ada#785
mcollina commentedon Dec 17, 2024
UrlPattern promotes a bad, non-performant pattern for server-side code, unless a
UrlPatternList(or Trie) is added as well. This is discussed in whatwg/urlpattern#30 (comment) and whatwg/urlpattern#166.I don't think we should be adding this without a
UrlPatternListcounterpart.anonrig commentedon Jan 3, 2025
I've opened a pull-request for URLPattern. It's far from complete but the progress is now public.
jasnell commentedon Jan 3, 2025
I agree that we should also have URLPatternList but that can/should be implemented second.
anonrig commentedon Feb 1, 2025
URLPattern pull-request landed.