Skip to content

implement URLPattern #40844

Closed
Closed

Description

@jimmywarting

Don't know if you have heard of this new URLPattern
Deno shipped it, and browser supports it, would be a cool util to have globally avalible to pear up with web standards and for usage in express routing for instance

Activity

  1. DerekNonGeneric commented on Nov 18, 2021

    @DerekNonGeneric
    Contributor

    Thanks for the heads up — obviously our feature request template is not very well-suited for these kinds of issues, but given that the specification for URLPattern is still in draft, I imagine that we would be setting the Webcompat Priority value of this to either ? or revisit if we were to use a triage system similar to what Mozilla uses for their WebCompat Tracking and Triage workflow.

    Mainly being a volunteer-run organization, we have no real priorities (whatever gets done, gets done); that being said, this issue cannot be represented by one of the N values in that system…

    I would say to perhaps set it as revisit and come back later once spec becomes a recommendation.

  2. changed the title [-]impl URLPattern[/-] [+]implement URLPattern[/+] on Nov 18, 2021
  3. added
    whatwg-urlIssues and PRs related to the WHATWG URL implementation.
    on Nov 18, 2021
  4. targos commented on Nov 21, 2021

    @targos
    Member
  5. targos commented on Nov 21, 2021

    @targos
    Member

    @nodejs/url what do you think?

  6. Jamesernator commented on Nov 23, 2021

    @Jamesernator

    Deno shipped it, and browser supports it, would be a cool util to have globally avalible to pear up with web standards and for usage in express routing for instance

    So I opened the original issue for support in Deno, I opened it on Deno as Deno tends to support considerably more cutting edge things.

    Having said this, having it Node would be particularly valuable for libraries that are currently using path-to-regexp for patterns. The syntax is essentially the same (aside from a few bug fixes to work with URLs more generally), so libraries that are currently using path-to-regexp could use the builtin URLPattern instead, allowing them to remove a external dependency.

    And having a common pattern syntax for things like routing would just generally be nice to have, so that libraries don't have a bunch of different microsyntaxes for essentially the same thing.

  7. jasnell commented on Nov 23, 2021

    @jasnell
    Member

    @targos ... I'm +1 on an having an implementation in core. I have some concerns about the performance as spec'd but having an implementation makes sense.

  8. moved this to Awaiting triage in Node.js feature requestson Jan 16, 2022
  9. moved this from Pending Triage to In Progress in Node.js feature requestson Feb 25, 2022
  10. linked a pull request that will close this issueurl: add experimental URLPattern #42133on Feb 25, 2022
  11. github-actions commented on Aug 25, 2022

    @github-actions
    Contributor

    There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

    For more information on how the project manages feature requests, please consult the feature request management document.

  12. added
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Aug 25, 2022
  13. github-actions commented on Sep 24, 2022

    @github-actions
    Contributor

    There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

    For more information on how the project manages feature requests, please consult the feature request management document.

  14. 7 remaining items

  15. moved this from Pending Triage to Todo in Node.js feature requestson Mar 22, 2023
  16. mharis commented on Mar 30, 2023

    @mharis

    +1

  17. bj-nostra commented on Apr 4, 2023

    @bj-nostra

    +1

  18. jimmywarting commented on Apr 4, 2023

    @jimmywarting
    Author

    Stop posting +1

    Hello everyone,

    I've noticed that several people are posting "+1" on this issue thread. While I understand that this is meant to indicate support for the issue, it's actually causing a lot of unnecessary notifications for everyone who is subscribed to this thread. Additionally, posting "+1" does not add any meaningful contribution to the conversation and only make scrolling through the page more annoying in order to find the most meaningful comments.

    Instead of posting a comment with "+1", I suggest that you simply use the "subscribe" button at the top of the issue thread to receive updates. Additionally, if you want to show support, you can use the "thumbs up" reaction on the original post. This will help keep the thread clean and reduce notifications for everyone.

    I appreciate your interest in this issue, but please keep in mind that posting "+1" repeatedly can become frustrating and annoying to those who are subscribed. By using the subscribe button and reactions, we can keep the conversation focused and productive.

    I don't want to have to unsubscribe to this topic if more ppl are going to post +1

    Thank you for your understanding and cooperation.

  19. locked as too heated and limited conversation to collaborators on Apr 4, 2023
  20. anonrig commented on Apr 4, 2023

    @anonrig
    Member

    I've locked and limited the issue to collaborators.

  21. anonrig commented on May 9, 2023

    @anonrig
  22. moved this from Todo to In Progress in Node.js feature requestson May 9, 2023
  23. anonrig commented on Dec 12, 2024

    @anonrig
    Member

    I'm almost done with the implementation. I'll try to open a pull-request to Node.js by the end of this year: ada-url/ada#785

  24. mcollina commented on Dec 17, 2024

    @mcollina
    SponsorMember

    UrlPattern promotes a bad, non-performant pattern for server-side code, unless a UrlPatternList (or Trie) is added as well. This is discussed in whatwg/urlpattern#30 (comment) and whatwg/urlpattern#166.

    I don't think we should be adding this without a UrlPatternList counterpart.

  25. unlocked this conversation on Dec 22, 2024
  26. anonrig commented on Jan 3, 2025

    @anonrig
    Member

    I've opened a pull-request for URLPattern. It's far from complete but the progress is now public.

  27. jasnell commented on Jan 3, 2025

    @jasnell
    Member

    I don't think we should be adding this without a UrlPatternList counterpart.

    I agree that we should also have URLPatternList but that can/should be implemented second.

  28. anonrig commented on Feb 1, 2025

    @anonrig
    Member

    URLPattern pull-request landed.

    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    discussIssues opened for discussion and feedback.feature requestIssues requesting new Node.js features.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions