Skip to content

v14.17.5 fails to build if configured with --shared-cares #39747

Closed
Closed
v14.17.5 fails to build if configured with --shared-cares#39747
Labels
caresIssues and PRs related to the c-ares dependency or the cares_wrap binding.

Description

@asavah
asavah
opened on Aug 12, 2021

Version

v14.17.5

Platform

Linux kross-1910 5.11.0-25-generic #27-Ubuntu SMP Fri Jul 9 23:06:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

configure node with --shared-cares which most linux distros use, try building it

How often does it reproduce? Is there a required condition?

always

What is the expected behavior?

Clean build

What do you see instead?

Build failure

In file included from ../src/cares_wrap.cc:25:
../src/cares_wrap.h:25:11: fatal error: ares_nameser.h: No such file or directory
   25 | # include <ares_nameser.h>
      |           ^~~~~~~~~~~~~~~~

Additional information

ares_nameser.h is a private header which is not installed to the system include dir.

4923b59 shouldn't have landed in LTS in its current state ...

Activity

  1. richardlau
    linked a pull request that will close this issuedeps: fix building with system c-ares on Linux #39739on Aug 12, 2021

  2. dilyanpalauzov commented on Aug 26, 2021

    @dilyanpalauzov
    dilyanpalauzov
    on Aug 26, 2021

    The same applies to v16.8.0 . libcares does not install ares_nameser.h , so the declarations from this file are not public.

  3. dilyanpalauzov commented on Aug 26, 2021

    @dilyanpalauzov
    dilyanpalauzov
    on Aug 26, 2021

    I see now at c-ares/c-ares@b9845b8 that the headers are now installed.

  4. Mesteery
    added
    caresIssues and PRs related to the c-ares dependency or the cares_wrap binding.
    on Sep 25, 2021
  5. BethGriggs
    added
    v12.x
    v14.x
    on Nov 15, 2021

  6. richardlau commented on Feb 17, 2022

    @richardlau
    richardlau
    on Feb 17, 2022
    Member

    This should now be fixed with the c-ares 1.18.1 in Node.js 12, 14, 16 and 17.

  7. richardlau
    closed this as completedon Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    caresIssues and PRs related to the c-ares dependency or the cares_wrap binding.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions