Readable[AsyncIterator] doesn't handle premature close #39086

Activity

1. ronag

   added

   streamIssues and PRs related to Node.js streams.Issues and PRs related to Node.js streams.

   good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.

   on Jun 19, 2021
2. daukadolt commented on Jun 19, 2021

   

   daukadolt

   on Jun 19, 2021

   More actions

   Sounds interesting, can I work on the issue?

   👍React with 👍1Reacted by Robert Nagy
3. daukadolt commented on Jun 21, 2021

   

   daukadolt

   on Jun 21, 2021

   Last edited by daukadolt

   More actions

   @ronag can you suggest the correct way to debug node's internal modules?

   I'm using Webstorm, and the debugger seems to ignore my breakpoints when it gets into internal modules, but works fine otherwise.

   
4. ronag commented on Jun 21, 2021

   

   ronag

   on Jun 21, 2021

   MemberAuthor

   More actions

   Sorry. I don’t use breakpoint debugging when working with node.
5. RaisinTen commented on Jun 22, 2021

   

   RaisinTen

   on Jun 22, 2021

   Member

   More actions

   PR: #39117

   😕React with 😕1Reacted by Daulet Amirkhanov
6. daukadolt commented on Jun 22, 2021

   

   daukadolt

   on Jun 22, 2021

   Last edited by daukadolt

   More actions

   That's confusing and discouraging from your side @RaisinTen.

   @ronag can you at least give a feedback on my PR?

   Upd: now that I've looked at RaisinTen's PR I see that there are still some parts that I'm missing.

   What does this part do?

   if (opts.destroyOnReturn || state.autoDestroy) {
           destroyImpl.destroyer(stream, err);
   }
7. RaisinTen commented on Jun 22, 2021

   

   RaisinTen

   on Jun 22, 2021

   Member

   More actions

   I'm sorry, I thought I could work on this as you didn't publish your PR.
8. RaisinTen commented on Jun 22, 2021

   

   RaisinTen

   on Jun 22, 2021

   Member

   More actions

   What does this part do?

   if (opts.destroyOnReturn || state.autoDestroy) {
           destroyImpl.destroyer(stream, err);
   }

   @daukadolt It destroys the stream if either the destroyOnReturn option or the autoDestroy option have been passed.

   👍React with 👍1Reacted by Daulet Amirkhanov
9. daukadolt commented on Jun 22, 2021

   

   daukadolt

   on Jun 22, 2021

   More actions

   But I was still working on it 😞 I don't remember any time limit on PR from Contributing.md.

   I'm new to the project, so it took me a while to read Contributing.md and all MD's that followed + Readable's internals

   👍React with 👍1Reacted by Chloe Brett
10. RaisinTen commented on Jun 22, 2021

    

    RaisinTen

    on Jun 22, 2021

    Member

    More actions

    There is no time limit on PRs. Anyone can work on any issue whenever they want to without asking for any permission. I didn't know much about the internal code of readable streams either, so I thought it would be nice to shoot a PR and learn few things about it.

    👍React with 👍1Reacted by wong2
11. daukadolt commented on Jun 22, 2021

    

    daukadolt

    on Jun 22, 2021

    More actions

    Can we agree to let me finish the ticket then, @RaisinTen?

    👍React with 👍1Reacted by Chloe Brett
12. RaisinTen commented on Jun 23, 2021

    

    RaisinTen

    on Jun 23, 2021

    Member

    More actions

    @daukadolt No one is stopping you. Please feel free to continue your work. :)
13. nodejs-github-bot

    closed this as completedin b2ae12don Jul 5, 2021
14. MayaLekova

    added a commit that references this issue on May 22, 2026

    stream: throw on premature close in Readable[AsyncIterator]

    ...

    b2ae12d