Skip to content

Benchmark CI run error: benchmark/_test-double-benchmarker #34061

Closed as not planned

Description

@rickyes

Run command:

./node-master benchmark/compare.js --old ./node-master --new ./node-master -- http2

Refs: #33928 (comment)

  • Test: http2
  • Platform: macOS,Linux
  • Console Output:
/Users/ricky/projj/github.com/rickyes/node/benchmark/_test-double-benchmarker.js:40
    client.on('error', (e) => { throw e; });
                                ^

Error: connect EADDRNOTAVAIL 127.0.0.1:12346 - Local (0.0.0.0:0)
    at internalConnect (net.js:905:16)
    at defaultTriggerAsyncIdScope (internal/async_hooks.js:416:12)
    at net.js:997:9
    at processTicksAndRejections (internal/process/task_queues.js:75:11) {
  errno: -49,
  code: 'EADDRNOTAVAIL',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 12346
}
Error: test-double-http2 failed with 1.
    at ChildProcess.<anonymous> (/Users/ricky/projj/github.com/rickyes/node/benchmark/_http-benchmarkers.js:238:16)
    at Object.onceWrapper (events.js:421:26)
    at ChildProcess.emit (events.js:314:20)
    at maybeClose (internal/child_process.js:1051:16)
    at Socket.<anonymous> (internal/child_process.js:442:11)
    at Socket.emit (events.js:314:20)
    at Pipe.<anonymous> (net.js:656:12)

Activity

  1. added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Jun 26, 2020
  2. changed the title [-]Benchmark CI run error[/-] [+]Benchmark CI run error: benchmark/_test-double-benchmarker[/+] on Jul 19, 2020
  3. rickyes commented on Jul 24, 2020

    @rickyes
    ContributorAuthor

    @jasnell @Trott I can't find a way to fix it. Any good suggestions?

  4. Trott commented on Jul 24, 2020

    @Trott
  5. Trott commented on Jul 24, 2020

    @Trott
    Member

    Is something else running on port 12346 on your machine? If so, you can tell it to use a different port with the NODE_COMMON_PORT environment variable:

    NODE_COMMON_PORT=8080 ./node-master benchmark/compare.js --old ./node-master --new ./node-master -- http2
    

    Oops, I made a small-but-important error. In tests, it's NODE_COMMON_PORT but apparently in benchmarks, it's just PORT:

    PORT=8080 ./node-master benchmark/compare.js --old ./node-master --new ./node-master -- http2
    

    Note, that I haven't tested this but determined it from reading the code. Sorry if I'm wrong again!

  6. rickyes commented on Jul 25, 2020

    @rickyes
    ContributorAuthor

    Is something else running on port 12346 on your machine? If so, you can tell it to use a different port with the NODE_COMMON_PORT environment variable:

    NODE_COMMON_PORT=8080 ./node-master benchmark/compare.js --old ./node-master --new ./node-master -- http2
    

    Oops, I made a small-but-important error. In tests, it's NODE_COMMON_PORT but apparently in benchmarks, it's just PORT:

    PORT=8080 ./node-master benchmark/compare.js --old ./node-master --new ./node-master -- http2
    

    Note, that I haven't tested this but determined it from reading the code. Sorry if I'm wrong again!

    It may not be port usage, I don't have any other programs using port 12346 on my machine, it could be a connection overload error.

  7. rickyes commented on Jul 30, 2020

    @rickyes
    ContributorAuthor

    It doesn't always happen, but the odds are good that it will.

  8. rickyes commented on Aug 2, 2020

    @rickyes
    ContributorAuthor

    @addaleax @BridgeAR Any good direction, maybe because the number of threads exceeds the number of connections?

  9. Trott commented on Aug 7, 2020

    @Trott
    Member

    If benchmarking is being throttled by the OS, I'm not sure I have a great suggestion, but maybe someone on @nodejs/benchmarking or @mscdex might have an idea.

  10. rickyes commented on Aug 9, 2020

    @rickyes
    ContributorAuthor

    ping again @mscdex @nodejs/benchmarking

  11. github-actions commented on Jun 27, 2026

    @github-actions
    Contributor

    This issue has been marked as stale due to 210 days of inactivity.
    It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

  12. added
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Jun 27, 2026
  13. github-actions commented on Jul 28, 2026

    @github-actions
    Contributor

    This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
    If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions