Documentation writable stream example confusing order #30759

Activity

1. devsnek

   added

   docIssues and PRs related to Node.js documentation.Issues and PRs related to Node.js documentation.

   streamIssues and PRs related to Node.js streams.Issues and PRs related to Node.js streams.

   on Dec 3, 2019
2. dev-script commented on Dec 3, 2019

   

   dev-script

   on Dec 3, 2019

   Contributor

   More actions

   @GrosSacASac i would like to work on this issue.

   👍React with 👍2Reacted by GrosSacASacs and Alex Yang
3. dev-script commented on Dec 10, 2019

   

   dev-script

   on Dec 10, 2019

   Contributor

   More actions

   Hello @GrosSacASac , i want to ask one query.

   The 'finish' event is emitted after the stream.end() method has been called, and all data has been flushed to the underlying system. so here i have to change 'after the stream.end()' line also.
4. GrosSacASac commented on Dec 10, 2019

   

   GrosSacASac

   on Dec 10, 2019

   ContributorAuthor

   More actions

   I am not sure what you mean exactly ?

   You can always make a PR it does not need to be perfect, you can always do follow up commits if something needs to be changed.
5. dev-script commented on Dec 10, 2019

   

   dev-script

   on Dec 10, 2019

   Contributor

   More actions

   I am not sure what you mean exactly ?

   You can always make a PR it does not need to be perfect, you can always do follow up commits if something needs to be changed.

   ok
6. Trott

   closed this as completedin 08728a1on Dec 13, 2019
7. MylesBorins

   added a commit that references this issue on Dec 17, 2019

   doc: improve doc writable streams: 'finish' event

   ...

   b53e2a8
8. targos

   added a commit that references this issue on Jan 14, 2020

   doc: improve doc writable streams: 'finish' event

   ...

   690deaa
9. BethGriggs

   added a commit that references this issue on Feb 6, 2020

   doc: improve doc writable streams: 'finish' event

   ...

   be4fffe