Skip to content

We could use your help improving Node.js' Windows testing #29852

Description

@bcoe
  • Version: head
  • Platform: Windows
  • Subsystem: test

I've been noticing windows tests flapping more than usual for the past few days:

https://ci.nodejs.org/job/node-test-binary-windows-2/3344/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=0/

https://ci.nodejs.org/job/node-test-binary-windows-2/3341/

We could use some help digging into this, it would be a great first contribution.


Known issues

If you're working on a specific issue, chime in on this thread and create an issue referencing it.

  • test/parallel/test-child-process-fork-exec-path:
    Error: ENOTEMPTY: directory not empty, rmdir 'c:\workspace\node-test-binary-windows- 
     2\test\.tmp.124'
     at Object.rmdirSync (fs.js:779:3)
     at rmdirSync (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:86:10)
     at rimrafSync (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:41:7)
  • test/parallel/test-http2-client-upload:
    events.js:187
          throw er; // Unhandled 'error' event
          ^
    Error: read ECONNRESET
        at TCP.onStreamRead (internal/stream_base_commons.js:201:27)
  • test/sequential/test-http2-large-file:
       events.js:187
          throw er; // Unhandled 'error' event
          ^
    
    Error: read ECONNRESET
        at TCP.onStreamRead (internal/stream_base_commons.js:201:27)
  • test/parallel/test-child-process-pipe-dataflow (see: flaky: test-child-process-pipe-dataflow #25988):
    assert.js:93
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: child 1 exited with code 1
        at ChildProcess.<anonymous> (c:\workspace\node-test-binary-windows-2\test\parallel\test- 
    child-process-pipe-dataflow.js:49:14)
    
  • parallel/test-http2-* (see: flaky: parallel/test-http2-* on Windows #20750).
  • test/async-hooks/test-statwatcher.
    fail (1)
    Stacktrace
    Watcher: w1
    current stat data: Stats {
      dev: 748388947,
      mode: 33206,
      nlink: 1,
      uid: 0,
      gid: 0,
      rdev: 0,
      blksize: 4096,
    
  • out of memory issues when spawning subprocesses (see: child_process: child_process.spawn ENOMEM on Windows  #25484, talk to @coreyfarrell for more details).

Getting Started

  1. read BUILDING.md for instructions on building for Windows.
  2. once you've built Node.js, you can run individual tests simply by invoking (./node test/parallel/test-xyz.js, where test-xyz.js is the test you wish to run).
  3. once you're making some progress on a bug comment on this thread, and it will help ensure that other folks don't take the same issue.
  4. recent Windows builds can be found here, if you want to dig further https://ci.nodejs.org/job/node-test-commit-windows-fanned/

Activity

  1. added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    help wantedIssues that need assistance from volunteers or PRs that need help to proceed.
    on Oct 5, 2019
  2. bcoe commented on Oct 5, 2019

    @bcoe
    Author
  3. ganes1410 commented on Oct 5, 2019

    @ganes1410

    @bcoe Can I look into this?

  4. bcoe commented on Oct 5, 2019

    @bcoe
    Author
  5. richardlau commented on Oct 5, 2019

    @richardlau
  6. added
    windowsIssues and PRs related to the Windows platform.
    on Oct 5, 2019
  7. bcoe commented on Oct 6, 2019

    @bcoe
    ContributorAuthor

    @ganes1410 👋 I've updated the original issue with more details about getting started.

    @richardlau, I've added the issue you linked.

  8. changed the title [-]Windows tests appear to be flapping on head[/-] [+]We could use your help improving Node.js' Windows testing[/+] on Oct 7, 2019
  9. ganes1410 commented on Oct 7, 2019

    @ganes1410

    sure @bcoe. I have completed the initial setup. I'll let you know in this issue once I have some progress

  10. Trott commented on Oct 9, 2019

    @Trott
    Member

    @nodejs/platform-windows

  11. bcoe commented on Jan 18, 2021

    @bcoe
    ContributorAuthor

    I think this issue is likely a bit stale at this point, let's open a new one if we notice CI failures in Windows are again cropping up too frequently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions