eos and stream type detection

Looking at https://github.com/nodejs/node/blob/master/lib/internal/streams/end-of-stream.js#L31

It looks like "eos" uses the writable and readable properties to detect whether a stream is Readablelike or Writablelike. However, according my current incomplete understanding of these properties (#29377), they cannot/should not be used for this purpose, i.e. a Readable stream could in theory have a readable = false which later becomes a readable = true.

Should we maybe change these lines to something like e.g:

const isReadable = (
  typeof stream.readable === 'boolean' || 
  stream._readableState || 
  typeof stream.readableEnded === 'boolean'
);
let readable = opts.readable || (opts.readable !== false && isReadable);

@mscdex

ping @mscdex @mcollina

You are correct. You cannot desume if something is going to be readable/writable in the future by looking at those properties, only if it could be readable/writable now. I think we should improve eos in this regard.

I think we can assume that is something a readable and is not destroyed it will become readable at some point.

I think what we primarily need to improve is how we detect whether something is Writable or Readable, agree?

stream: use more accurate end-of-stream writable and readable detection

This has been fixed.

stream: use more accurate end-of-stream writable and readable detection

Navigation Menu

Repository navigation

eos and stream type detection #29395

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

eos and stream type detection #29395

Description

Activity

ronag commented on Sep 1, 2019

mcollina commented on Sep 2, 2019

ronag commented on Sep 2, 2019

ronag commented on Oct 6, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions