Skip to content

build,cares,openssl,zlib: limit symbol exports #27664

Closed as not planned
Closed as not planned
build,cares,openssl,zlib: limit symbol exports#27664
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.opensslIssues and PRs related to the OpenSSL dependency.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.

Description

@bnoordhuis
bnoordhuis
opened on May 13, 2019

Refs: #4932 #6274

On Windows, Node exports a curated list of symbols from its dependencies that don't use dllimport/dllexport (c-ares, openssl, zlib)

On Unices, Node indiscriminately re-exports everything thanks to -Wl,--whole-archive.

There's a comment about it in node.gyp:

# TODO(bnoordhuis) Make all platforms export the same list of symbols.
# Teach mkssldef.py to generate linker maps that UNIX linkers understand.

It would be good to implement that. It should help trim down the binary size.

Activity

  1. bnoordhuis
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    opensslIssues and PRs related to the OpenSSL dependency.
    on May 13, 2019
  2. bnoordhuis
    changed the title [-]build,openssl: limit symbol exports[/-] [+]build,cares,openssl,zlib: limit symbol exports[/+] on May 13, 2019

  3. sam-github commented on May 13, 2019

    @sam-github
    sam-github
    on May 13, 2019
    Contributor

    /cc @nicolasnoble

  4. bnoordhuis commented on May 18, 2019

    @bnoordhuis
    bnoordhuis
    on May 18, 2019
    MemberAuthor

    nodejs/node-gyp#1755 points out that symbols from deps/histogram are also exported (and conflict with symbols from an add-on.)

  5. jasnell commented on Jun 26, 2020

    @jasnell
    jasnell
    on Jun 26, 2020
    Member

    @bnoordhuis ... what's left here to do?

  6. github-actions commented on Jun 27, 2026

    @github-actions
    github-actionsBot
    on Jun 27, 2026 – with GitHub Actions
    Contributor

    This issue has been marked as stale due to 210 days of inactivity.
    It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

  7. github-actions
    added
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Jun 27, 2026

  8. github-actions commented on Jul 28, 2026

    @github-actions
    github-actionsBot
    on Jul 28, 2026 – with GitHub Actions
    Contributor

    This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
    If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.

  9. github-actions
    closed this as not plannedon Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.opensslIssues and PRs related to the OpenSSL dependency.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions