Skip to content

Investigate flaky test test-child-process-emfile #2666

Closed
Closed
Investigate flaky test test-child-process-emfile#2666
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.child_processIssues and PRs related to the child_process subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@joaocgreis
joaocgreis
opened on Sep 2, 2015

Examples of failures:

Ref: #2636 (comment)

Activity

  1. joaocgreis
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Sep 2, 2015

  2. joaocgreis commented on Sep 2, 2015

    @joaocgreis
    joaocgreis
    on Sep 2, 2015
    MemberAuthor

    Both happened in the new iojs-nodesource-raspbian-wheezy-pi2-7-mininodes

  3. joaocgreis commented on Sep 2, 2015

    @joaocgreis
    joaocgreis
    on Sep 2, 2015
    MemberAuthor

    Another one, again in pi2-7

  4. orangemocha
    added a commit that references this issue on Sep 3, 2015

    test: test-child-process-emfile is flaky

    eeac5da

  5. Fishrock123 commented on Sep 3, 2015

    @Fishrock123
    Fishrock123
    on Sep 3, 2015
    Contributor

    Why don't these tests show error output?

  6. brendanashworth
    added
    child_processIssues and PRs related to the child_process subsystem.
    on Sep 3, 2015

  7. rvagg commented on Sep 3, 2015

    @rvagg
    rvagg
    on Sep 3, 2015
    Member

    rebooted pi2-7, just in case it's something related to just being set up yesterday and not having a reboot since

  8. skomski commented on Sep 3, 2015

    @skomski
    skomski
    on Sep 3, 2015
    Contributor

    @Fishrock123 because they timed out - pr #2647 would make that visible

  9. jbergstroem commented on Sep 3, 2015

    @jbergstroem
    jbergstroem
    on Sep 3, 2015
    Member

    Can't say I've seen this around either.

  10. joaocgreis commented on Sep 3, 2015

    @joaocgreis
    joaocgreis
    on Sep 3, 2015
    MemberAuthor

    Different platform: centos5-32: https://ci.nodejs.org/job/node-test-commit-linux/462/nodes=centos5-32/console

  11. Trott commented on Oct 13, 2015

    @Trott
    Trott
    on Oct 13, 2015
    Member

    Seems to mostly/only fail on FreeBSD lately. #3335 isn't a fix but may at least help point someone in the right direction.

  12. Trott commented on Oct 19, 2015

    @Trott
    Trott
    on Oct 19, 2015
    Member

    The test treats ENFILE the same as EMFILE. But ENFILE is a race condition because another process can trigger it temporarily. That seems to be the cause of the flakiness. PR coming momentarily.

  13. Trott commented on Oct 19, 2015

    @Trott
    Trott
    on Oct 19, 2015
    Member

    Proposed fix in #3430

  14. Trott
    closed this as completedin d89bc7bon Oct 20, 2015
  15. Trott
    added 3 commits that reference this issue on Oct 21, 2015

    test: fix flaky test-child-process-emfile

    04fb14c

    test: fix flaky test-child-process-emfile

    0b32414

    test: fix flaky test-child-process-emfile

    a5d968b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.child_processIssues and PRs related to the child_process subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions