Skip to content

Investigate flaky test-crypto-timing-safe-equal-benchmarks #25984

Closed
Closed
Investigate flaky test-crypto-timing-safe-equal-benchmarks#25984
Labels
cryptoIssues and PRs related to the crypto subsystem.flaky-testIssues and PRs involving tests that fail intermittently in CI.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@Trott
Trott
opened on Feb 7, 2019

https://ci.nodejs.org/job/node-test-commit-custom-suites/864/default/console

test-rackspace-ubuntu1604-x64-1

00:05:42 not ok 62 pummel/test-crypto-timing-safe-equal-benchmarks
00:05:42   ---
00:05:42   duration_ms: 27.177
00:05:42   severity: fail
00:05:42   exitcode: 1
00:05:42   stack: |-
00:05:42     assert.js:351
00:05:42         throw err;
00:05:42         ^
00:05:42     
00:05:42     AssertionError [ERR_ASSERTION]: timingSafeEqual should not leak information from its execution time (t=4.860941889108833)
00:05:42         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-custom-suites/default/test/pummel/test-crypto-timing-safe-equal-benchmarks.js:106:1)
00:05:42         at Module._compile (internal/modules/cjs/loader.js:735:30)
00:05:42         at Object.Module._extensions..js (internal/modules/cjs/loader.js:746:10)
00:05:42         at Module.load (internal/modules/cjs/loader.js:627:32)
00:05:42         at tryModuleLoad (internal/modules/cjs/loader.js:570:12)
00:05:42         at Function.Module._load (internal/modules/cjs/loader.js:562:3)
00:05:42         at Function.Module.runMain (internal/modules/cjs/loader.js:798:12)
00:05:42         at internal/main/run_main_module.js:27:11
00:05:42   ...

Activity

  1. Trott
    added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Feb 7, 2019

  2. Trott commented on Feb 7, 2019

    @Trott
    Trott
    on Feb 7, 2019
    MemberAuthor

    @nodejs/crypto

  3. Trott commented on Feb 7, 2019

    @Trott
    Trott
    on Feb 7, 2019
    MemberAuthor

    @not-an-aardvark

  4. Trott
    added
    cryptoIssues and PRs related to the crypto subsystem.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Feb 7, 2019

  5. Trott commented on Feb 20, 2019

    @Trott
    Trott
    on Feb 20, 2019
    MemberAuthor

    https://ci.nodejs.org/job/node-test-commit-custom-suites/880/default/console

    test-rackspace-ubuntu1604-x64-1

    00:07:31 not ok 62 pummel/test-crypto-timing-safe-equal-benchmarks
00:07:31   ---
00:07:31   duration_ms: 120.98
00:07:31   severity: fail
00:07:31   exitcode: -15
00:07:31   stack: |-
00:07:31     timeout
00:07:31   ...

  6. Trott commented on Feb 20, 2019

    @Trott
    Trott
    on Feb 20, 2019
    MemberAuthor

    Last successful run took 52 seconds. If there's significant randomness involved (which seems possible given that it's crypto), then a two minute timeout might be an expected result from time to time. But I don't actually know.

  7. Trott commented on Feb 20, 2019

    @Trott
    Trott
    on Feb 20, 2019
    MemberAuthor

    Last successful run took 52 seconds. If there's significant randomness involved (which seems possible given that it's crypto), then a two minute timeout might be an expected result from time to time. But I don't actually know.

    Meh, maybe not. Successful results are pretty consistent in duration. 52 seconds, 53 seconds, 52 seconds....

  8. Trott
    added a commit that references this issue on Feb 20, 2019

    test: add (temporary) logging for unreliable test

    e76d10f

  9. Trott commented on Feb 21, 2019

    @Trott
    Trott
    on Feb 21, 2019
    MemberAuthor

    Cause is #26229.

  10. Trott
    closed this as completedin eb9e6c0on Feb 22, 2019
  11. addaleax
    added a commit that references this issue on Feb 25, 2019

    test: improve performance of test-crypto-timing-safe-equal-benchmarks

    68b6dc8
  12. rvagg
    added a commit that references this issue on Feb 28, 2019

    test: improve performance of test-crypto-timing-safe-equal-benchmarks

    ca18525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cryptoIssues and PRs related to the crypto subsystem.flaky-testIssues and PRs involving tests that fail intermittently in CI.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions