You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I walked through the recent 100 CI runs and this failure seems to only happen in test-worker-messageport-transfer-terminate, so I suspect the internalBinding causing this should be either worker or messaging.
The binding in question should be uv, based on the disassembly of my failed build, so I would be reasonably certain this is being addressed by #25079 – I’ll land it, add a Fixes: tag and we can re-open if necessary.
Activity
joyeecheung commentedon Dec 19, 2018
I walked through the recent 100 CI runs and this failure seems to only happen in
test-worker-messageport-transfer-terminate, so I suspect the internalBinding causing this should be eitherworkerormessaging.cc @nodejs/workers @addaleax
joyeecheung commentedon Dec 19, 2018
The first failure in CI is rebasing onto #25076 (which added this test)
addaleax commentedon Dec 19, 2018
I can reproduce this locally.
The binding in question should be
uv, based on the disassembly of my failed build, so I would be reasonably certain this is being addressed by #25079 – I’ll land it, add aFixes:tag and we can re-open if necessary.src: handle empty Maybe in uv binding initialize
src: handle empty Maybe in uv binding initialize
src: handle empty Maybe in uv binding initialize
src: handle empty Maybe in uv binding initialize