Skip to content

[v8.x] flaky sequential/test-http2-settings-flood #25043

Closed
Closed
[v8.x] flaky sequential/test-http2-settings-flood#25043
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.http2Issues and PRs related to the http2 subsystem.

Description

@mcollina
mcollina
opened on Dec 14, 2018

In a recent CI run there was a crash sequential/test-http2-settings-flood

13:27:16 not ok 528 sequential/test-http2-settings-flood
13:27:16   ---
13:27:16   duration_ms: 1.37
13:27:16   severity: crashed
13:27:16   exitcode: -1073741819
13:27:16   stack: |-
  • Version: master
  • Platform: Windows
  • Subsystem: http2

Activity

  1. mcollina
    added
    http2Issues and PRs related to the http2 subsystem.
    on Dec 14, 2018

  2. mcollina commented on Dec 14, 2018

    @mcollina
    mcollina
    on Dec 14, 2018
    SponsorMemberAuthor

    cc @jasnell

  3. mcollina commented on Dec 14, 2018

    @mcollina
    mcollina
    on Dec 14, 2018
    SponsorMemberAuthor

    Prior art: #18251 #19349.

  4. mcollina commented on Dec 14, 2018

    @mcollina
    mcollina
    on Dec 14, 2018
    SponsorMemberAuthor

    cc @Trott

  5. Trott commented on Dec 14, 2018

    @Trott
    Trott
    on Dec 14, 2018
    Member

    Link to the CI run would be very useful. In particular, I think this was a CI run on the v8.x branch, was it not? It might be a bug that's already been fixed in master.

  6. Trott commented on Dec 14, 2018

    @Trott
    Trott
    on Dec 14, 2018
    Member

    Oh, wait, you wrote "master" above. Yeah, link would be good. Would want to know what Windows variant etc.

  7. Trott commented on Dec 14, 2018

    @Trott
    Trott
    on Dec 14, 2018
    Member

    Argh! http2. Yeah, that has to be master, not v8.x. I read it as https for some reason. Sorry for all the noise...

  8. Trott commented on Dec 14, 2018

    @Trott
    Trott
    on Dec 14, 2018
    Member

    Found one...

    https://ci.nodejs.org/job/node-test-binary-windows/22459/COMPILED_BY=vcbt2015,RUNNER=win10,RUN_SUBSET=1/console

    test-azure_msft-win10-x64-4

    09:53:40 not ok 529 sequential/test-http2-settings-flood
09:53:40   ---
09:53:40   duration_ms: 1.139
09:53:40   severity: crashed
09:53:40   exitcode: -1073741819
09:53:40   stack: |-
09:53:40   ...

    Timestamps are different than the console cut-and-paset from @mcollina so this has happened at least twice. Probably a good idea to mark it flaky until it gets worked out. One bugfix is probably going to resolve a ton of these flaky tests all at once.

  9. Trott
    added a commit that references this issue on Dec 14, 2018

    test: mark test-http2-settings-flood as flaky on Windows

    818a89c

  10. Trott commented on Dec 14, 2018

    @Trott
    Trott
    on Dec 14, 2018
    Member

    Argh! It IS v8.x after all! Yeah, this is probably not affecting master.

    (Why did I think http2 didn't exist in v8.x?)

  11. Trott
    added
    v8.x
    on Dec 14, 2018
  12. Trott
    changed the title [-]flaky sequential/test-http2-settings-flood[/-] [+][v8.x] flaky sequential/test-http2-settings-flood[/+] on Dec 14, 2018
  13. MylesBorins
    added a commit that references this issue on Dec 22, 2018

    test: mark test-http2-settings-flood as flaky on Windows

    2bedbdb

  14. MylesBorins commented on Dec 22, 2018

    @MylesBorins
    MylesBorins
    on Dec 22, 2018
    Contributor

    marked flaky on 8.x in 2bedbdb

  15. MylesBorins
    closed this as completedon Dec 22, 2018
  16. MylesBorins
    reopened this on Dec 22, 2018
  17. MylesBorins
    added a commit that references this issue on Dec 22, 2018

    test: mark test-http2-settings-flood as flaky on Windows

    aef71c0
  18. ChALkeR
    added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Nov 6, 2019

  19. BridgeAR commented on Jan 2, 2020

    @BridgeAR
    BridgeAR
    on Jan 2, 2020
    Member

    Node.js v8.x has reached the end-of-life and won't receive any fixes anymore. I am closing this since this issue only applies to Node.js v8.x.

  20. BridgeAR
    closed this as completedon Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.http2Issues and PRs related to the http2 subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions