close event emitted on net socket but not tls

Version: v11.4.0
Platform: Linux david-Latitude-E6440 4.18.0-12-generic Failed assert in AsyncWrap::MakeCallback(uint32_t, int, Handle) from test-timers-unref.js on ARM #13-Ubuntu SMP Wed Nov 14 15:17:05 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Subsystem: net, tls

Why does this emit a close event:

const fs = require('fs');
const path = require('path');
const net = require('net');
const server = net.createServer();

server.on('connection', function (conn) {
    conn.on('close', function () {
        console.log("CLOSE");
    });

    conn.resume();
    conn.end(Buffer.alloc(1024*1024));
});

server.listen(7000, function () {
    net.connect({
        port: 7000
    }, function () {
        this.end();
    });
});

but this does not emit a close event:

const fs = require('fs');
const path = require('path');
const tls = require('tls');
const server = tls.createServer({
    key: fs.readFileSync(path.join(__dirname, 'server.key')),
    cert: fs.readFileSync(path.join(__dirname, 'server.pem'))
});

server.on('secureConnection', function (conn) {
    conn.on('close', function () {
        console.log("CLOSE");
    });

    conn.resume();
    conn.end(Buffer.alloc(1024*1024));
});

server.listen(7000, function () {
    tls.connect({
        ca: fs.readFileSync(path.join(__dirname, 'ca.pem')),
        port: 7000
    }, function () {
        this.end();
    });
});

?

They both don't emit 'close' on my machine and the reason is that data is not read on the client. It works if this.resume() is added on the client.

OS TCP buffer size perhaps then

@lpinca

@lpinca what about this? I don't get a close event.

const fs = require('fs');
const path = require('path');
const tls = require('tls');
const server = tls.createServer({
    key: fs.readFileSync(path.join(__dirname, 'server.key')),
    cert: fs.readFileSync(path.join(__dirname, 'server.pem'))
});
let cconn = null;
let sconn = null;

function doit() {
    if (cconn && sconn) {
        cconn.resume();
        sconn.resume();
        sconn.end(Buffer.alloc(1024*1024));
        cconn.end();
    }
}

server.on('secureConnection', function (conn) {
    conn.on('close', function () {
        console.log("CLOSE");
    });
    sconn = conn;
    doit();
});

server.listen(7000, function () {
    tls.connect({
        ca: fs.readFileSync(path.join(__dirname, 'ca.pem')),
        port: 7000
    }, function () {
        cconn = this;
        doit();
    });
});

This fixes it:

diff --git a/lib/net.js b/lib/net.js
index 0229e450fc..377dd202af 100644
--- a/lib/net.js
+++ b/lib/net.js
@@ -371,8 +371,8 @@ Socket.prototype._final = function(cb) {
 };
 
 
-function afterShutdown(status, handle) {
-  var self = handle[owner_symbol];
+function afterShutdown(status) {
+  var self = this.handle[owner_symbol];
 
   debug('afterShutdown destroyed=%j', self.destroyed,
         self._readableState);

I can reproduce the issue, both 'end' and 'finish' are emitted but not 'close'.

@addaleax

cc: @addaleax

The first bad commit seems to be e82f67d710.

net: check for close on stream, not parent

Don't support Node 10 due to nodejs/node#24984

net: check for close on stream, not parent

Navigation Menu

Repository navigation

close event emitted on net socket but not tls #24984

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

close event emitted on net socket but not tls #24984

Description

Activity

lpinca commented on Dec 12, 2018

davedoesdev commented on Dec 12, 2018

davedoesdev commented on Dec 12, 2018

davedoesdev commented on Dec 13, 2018

lpinca commented on Dec 13, 2018

lpinca commented on Dec 13, 2018

lpinca commented on Dec 13, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions