-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
test: more tests for PKCS#8 private keys #24928
Copy link
Copy link
Closed
Labels
cryptoIssues and PRs related to the crypto subsystem.Issues and PRs related to the crypto subsystem.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.testIssues and PRs related to the tests.Issues and PRs related to the tests.
Metadata
Metadata
Assignees
Labels
cryptoIssues and PRs related to the crypto subsystem.Issues and PRs related to the crypto subsystem.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.testIssues and PRs related to the tests.Issues and PRs related to the tests.
We currently lack coverage for unencrypted PKCS#8 private keys (
-----BEGIN PRIVATE KEY-----) with the sole exception oftest/fixtures/foafssl.keyused intest/parallel/test-https-foafssl.js.Compare PKCS#1 private keys (
-----BEGIN RSA PRIVATE KEY-----) for which we have ample coverage.I count three tests that cover encrypted PKCS#8 keys (
-----BEGIN ENCRYPTED PRIVATE KEY-----):For unencrypted PKCS#8, it would be nice to have tests for at least RSA and DSA, with and without PEM attributes for bonus points. See
test/fixtures/foafssl.keyfor an example of attributes.cc @sam-github - possibly relevant to your interests