Repository navigation
Incorrect inspection of Set iterator for set.entries() #24629
Description
Activity
Object::PreviewEntries reports unkeyed and gives the flat array.
@nodejs/v8
Yeah, Chrome has the same behavior:
AFAIC this works as intended. With the change to using
Object::PreviewEntriesthis difference has been discussed as well and we decided to follow chrome.
The set entries only contain the values, so there is no need to display it as an array with the value duplicated.@BridgeAR its not an accurate representation of the actual iterator results though...
> new Set([2, 4]).entries() [Set Iterator] { 2, 4 } > // oh ok its just some numbers > new Set([2, 4]).entries().next() { value: [ 2, 2 ], done: false } > // wait value is an array now? >
It's true that they contain the values but they are still in arrays, so IMHO it is confusing to not see that in the preview.
I just fixed
Object::PreviewEntriesto work as intended locally and I'll raise a PR to V8 as soon as I set up the whole machinery for V8 PRs and I'll backport that as soon as it lands.ruben@BridgeAR-T450s:~/repos/node/node$ ./node > a = new Set([1,2,3]) Set { 1, 2, 3 } > a.values() [Set Iterator] { 1, 2, 3 } > a.keys() [Set Iterator] { 1, 2, 3 } > a.entries() [Set Iterator] { [ 1, 1 ], [ 2, 2 ], [ 3, 3 ] } > process.versions { http_parser: '2.8.0', node: '12.0.0-pre', v8: '7.0.276.38-node.13',Refs: #20831 (the original PR that changed the behavior)
Reacted by Rich Trott, Jeremiah Senkpiel, Michaël Zasso and antsmartianReacted by Jeremiah Senkpiel and antsmartian@targos I have to fix the Node.js test expectation first in another PR for V8 as those tests will now fail (Which is intended). I am working on that.
The actual CL to fix the preview: https://chromium-review.googlesource.com/c/v8/v8/+/1350790
Reacted by Michaël Zasso- added a commit that references this issue
on Feb 4, 2019 3 remaining items
- added a commit that references this issue
on Feb 20, 2019 - added 2 commits that reference this issue
on Feb 21, 2019 - added 2 commits that reference this issue
on Feb 28, 2019 - added a commit that references this issue
on Mar 12, 2019 - added 2 commits that reference this issue
on Mar 12, 2019
In Node 6 and 8, it outputs:
In Node 10, 11 and master: