Repository navigation
test-make-doc now failing locally #19694
Description
- Version: master
- Platform: mac
- Subsystem: doc, test
I just pulled and test-make-doc is now failing:
$ out/Release/node /Users/matteo/Repositories/node/test/doctool/test-make-doc.js
assert.js:248
throw err;
^
AssertionError [ERR_ASSERTION]: all.html is empty
at Object.<anonymous> (/Users/matteo/Repositories/node/test/doctool/test-make-doc.js:47:10)
at Module._compile (internal/modules/cjs/loader.js:678:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)
at Module.load (internal/modules/cjs/loader.js:589:32)
at tryModuleLoad (internal/modules/cjs/loader.js:528:12)
at Function.Module._load (internal/modules/cjs/loader.js:520:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:719:10)
at startup (internal/bootstrap/node.js:225:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:572:3)
This as been introduced in #19581. Not sure what I should do to make this pass again on my machine, I already tried make clean and make doc.
Activity
[-]test-make-dock now failing locally[/-][+]test-make-doc now failing locally[/+]mcollina commentedon Mar 30, 2018
cc @vsemozhetbyt
vsemozhetbyt commentedon Mar 30, 2018
Throwing assertion.
Cause of the added check:
all.htmlfile inout/doc/apifolder?all.htmlis not broken during the process?vsemozhetbyt commentedon Mar 30, 2018
Can there also be some race condition? Can
doctool/test-make-doc.jsrun till doc building is finished?mcollina commentedon Mar 30, 2018
Yes it is empty,.
how?
This fails even if I run this individually, after
make dochas finished. There shouldn't be race conditions.I do not understand. can you rephrase?
vsemozhetbyt commentedon Mar 30, 2018
Maybe run
make doc-onlyafter deletedout/doc/apifolder and check the output on console? There should be lines concerning all the doc files. (~102)It seems this is not possible if you "run this individually, after make doc has finished." I thought there may be parallel processes of doc building and tests,
mcollina commentedon Mar 30, 2018
That did the trick. I think we should have
make cleanremove this folder as well.lpinca commentedon Mar 31, 2018
make distcleanalready deletes the wholeoutfolder.mcollina commentedon Mar 31, 2018
Following the principle of least surprise, a developer expects make clean to restore the tree in a state that would have “make test” pass.
vsemozhetbyt commentedon Mar 31, 2018
Is there a way to make
makerebuild a doc if it is empty?joyeecheung commentedon Mar 31, 2018
+1. Anyone knows why
make cleandoes not just wipe theoutfolder? cc @nodejs/buildMylesBorins commentedon May 4, 2018
Just got hit by this on 10.x-staging
jasnell commentedon Oct 19, 2018
I think this is resolved now?