Repository navigation
C++ coverage broken #18402
Description
Activity
that's weird. let me build the coverage locally and see if I can find anything.
[Edit]
It only verifiednode_main.ccfor now and that's why it shows100%@addaleax you're right. it's because of my change. only the final executable (node_main.cc) and shared lib have
--coverageldflages and cflags after my change. The condition check for coverage is mangled with other conditions. I will try to separate it from others.@mhdawson for me, the fix is quite easy. It just missed the
--coveragecflags when we need a coverage build. and before my change, the--coverageis mangled with other condition check, I separated it now. The only thing left is the latest CI failures here: https://ci.nodejs.org/job/node-test-commit-linux/15961/.And the fix actually only affects the case that
--coverageis specified. When running the CI, coverage is off.This does not land cleanly on v9.x
Not sure if the coverage is broken on that branch, but we likely want to backport a fix if it is
@MylesBorins are you talking about #18409 ?
https://coverage.nodejs.org/ displays 100 % C++ coverage for commits since 8229fc0...f878f94. I don’t see anything obvious that changed here, but f878f94 changed a sizeable part of node.gyp so that might be it?
/cc @mhdawson @yhwang