Skip to content

Need to update source exclusions for ICU 61 #16937

Closed
Closed
Need to update source exclusions for ICU 61#16937
Assignees
srl295
Labels
c++Issues and PRs that require attention from people who are familiar with C++.i18n-apiIssues and PRs related to Node.js internationalization support.

Description

@srl295
srl295
opened on Nov 10, 2017
  • Platform: all
  • Subsystem: deps

#16876 landed ICU 60.1 but didn't update the source exclusions in icu_generic.gyp. As a result:

  • too many files are built- increases binary size, and source size (this also controls what is checked into the repo)
  • there's more exposure for platform build issues (probably a minor point)

This would cause NO change in actual behavior, because the files aren't actually executed (or their removal would have caused the build to fail).

Activity

  1. srl295
    self-assigned this
    on Nov 10, 2017

  2. srl295 commented on Nov 10, 2017

    @srl295
    srl295
    on Nov 10, 2017
    MemberAuthor

    should have read the guide in #7843 !

  3. srl295 commented on Nov 10, 2017

    @srl295
    srl295
    on Nov 10, 2017
    MemberAuthor

    OK, looking at the exclusions: I only put them in for 55 and 57 (copy and paste). So they are missing for 56(#3281), 58 (#9234/#10206), 59 (#12486) AND 60 (#16876). So this is not a new issue.

    Also fixing this now would break the floating patch #16931 without some care. (it could be re-applied)

    Eminently back-port-able.

    Instead of copy and paste, a range should be used for exclusions.

  4. srl295
    added
    c++Issues and PRs that require attention from people who are familiar with C++.
    i18n-apiIssues and PRs related to Node.js internationalization support.
    on Nov 10, 2017

  5. srl295 commented on Jan 30, 2018

    @srl295
    srl295
    on Jan 30, 2018
    MemberAuthor

    ^ floating patch mentioned above is rolled into the #17687 so shouldn't be a problem.

  6. apapirovski commented on Apr 13, 2018

    @apapirovski
    apapirovski
    on Apr 13, 2018
    Contributor

    @srl295 was this fixed when #17687 landed?

  7. srl295
    changed the title [-]Need to update source exclusions for ICU 60[/-] [+]Need to update source exclusions for ICU 61[/+] on Apr 13, 2018

  8. srl295 commented on Apr 13, 2018

    @srl295
    srl295
    on Apr 13, 2018
    MemberAuthor

    @apapirovski no, this a minor improvement is to add some more exclusions. It was unblocked by the above. Should now be 61 due to #19621

  9. jasnell commented on Aug 11, 2018

    @jasnell
    jasnell
    on Aug 11, 2018
    Member

    @srl295 ... still needed?

  10. srl295
    closed this as completedon May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c++Issues and PRs that require attention from people who are familiar with C++.i18n-apiIssues and PRs related to Node.js internationalization support.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions