Skip to content

Flaky stringbytes-external-exceed-max tests on FreeBSD 10-64 #16354

Closed
Closed
Flaky stringbytes-external-exceed-max tests on FreeBSD 10-64#16354
Labels
bufferIssues and PRs related to the buffer subsystem.flaky-testIssues and PRs involving tests that fail intermittently in CI.freebsdIssues and PRs related to the FreeBSD platform.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@joyeecheung
joyeecheung
opened on Oct 21, 2017
  • Version: master
  • Platform: freebsd10-64
  • Subsystem: test

Sample

This is constantly showing up in unrelated PR jobs.

not ok 1807 addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max
  ---
  duration_ms: 178.295
  severity: fail
  stack: |-
    timeout
  ...

not ok 1810 addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-binary
  ---
  duration_ms: 127.104
  severity: fail
  stack: |-
    timeout
  ...

not ok 1811 addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex
  ---
  duration_ms: 154.918
  severity: fail
  stack: |-
    timeout

Activity

  1. joyeecheung
    added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Oct 21, 2017

  2. joyeecheung commented on Oct 21, 2017

    @joyeecheung
    joyeecheung
    on Oct 21, 2017
    MemberAuthor

    cc @nodejs/testing @nodejs/platform-freebsd

  3. targos commented on Oct 21, 2017

    @targos
    targos
    on Oct 21, 2017
    Member

    These tests started to timeout after the update to V8 6.2. It is most likely because the maximum string size is now 1GB on 64-bit systems.

  4. bnoordhuis
    added a commit that references this issue on Oct 21, 2017

    test: mark big string tests flaky on freebsd

    ffc04cf

  5. bnoordhuis commented on Oct 21, 2017

    @bnoordhuis
    bnoordhuis
    on Oct 21, 2017
    Member

    #16358

  6. mscdex
    added
    bufferIssues and PRs related to the buffer subsystem.
    freebsdIssues and PRs related to the FreeBSD platform.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Oct 21, 2017

  7. Trott commented on Oct 22, 2017

    @Trott
    Trott
    on Oct 22, 2017
    Member

    A few thoughts on this:

    • Maybe we just need a machine in CI with more RAM or something? (@nodejs/build)

    • I wonder if it's just a matter of tweaking common.enoughTestMem to skip on our FreeBSD 10 host?

    • Perhaps these tests should be moved to pummel?

    • Are removing these tests entirely a reasonable possibility?

  8. Trott commented on Oct 22, 2017

    @Trott
    Trott
    on Oct 22, 2017
    Member

    These tests are skipped on machines with less than 1 Gb of RAM. This machine that we're seeing failure on has 1.7-ish Gb of RAM. I'd be cool with moving the threshold up to 1.99 Gb of RAM, so 2Gb or more of RAM runs the test. Not sure how many other machines in CI that might cause the tests to skip on, but honestly, if these tests are only run on one or two platforms in CI, that's probably fine. Thoughts? @nodejs/testing @nodejs/build

  9. Trott
    added a commit that references this issue on Oct 22, 2017

    test: increase enoughTestMem to 1.75 Gb

    bbea46d

  10. Trott commented on Oct 22, 2017

    @Trott
    Trott
    on Oct 22, 2017
    Member

    Increasing common.enoughTestMem to 1.75 Gb seemed like a good idea to me, so: #16374

  11. Trott
    added a commit that references this issue on Oct 22, 2017

    test: increase enoughTestMem to 1.75 Gb

    53f4ac2
  12. Trott
    closed this as completedin 53f4ac2on Oct 22, 2017
  13. MylesBorins
    added a commit that references this issue on Oct 23, 2017

    test: increase enoughTestMem to 1.75 Gb

    3c41f3f
  14. addaleax
    added a commit that references this issue on Oct 26, 2017

    test: increase enoughTestMem to 1.75 Gb

    37842ac
  15. MylesBorins
    added 3 commits that reference this issue on Nov 16, 2017

    test: increase enoughTestMem to 1.75 Gb

    b613562

    test: increase enoughTestMem to 1.75 Gb

    5eabc57

    test: increase enoughTestMem to 1.75 Gb

    62dd6a2
  16. addaleax
    added a commit that references this issue on Dec 7, 2017

    test: increase enoughTestMem to 1.75 Gb

    224110e
  17. rvagg
    added a commit that references this issue on Aug 15, 2018

    test: call gc() explicitly to avoid OOM

    9feee1f
  18. MylesBorins
    added a commit that references this issue on Oct 2, 2018

    test: call gc() explicitly to avoid OOM

    d58867a
  19. firass111
    added a commit that references this issue on Apr 16, 2025

    test: call gc() explicitly to avoid OOM

    1d15f33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bufferIssues and PRs related to the buffer subsystem.flaky-testIssues and PRs involving tests that fail intermittently in CI.freebsdIssues and PRs related to the FreeBSD platform.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions