os.EOL constant issue

Version : v8.2.1
Platform: Windows (64 bit)

Code

const os = require('os');
console.log(os.EOL + " is the EOL");
os.EOL = "12345"
console.log(os.EOL + " is the EOL");

Output

 is the EOL
12345 is the EOL

os.EOL is specified as a constant but its value is getting updated

I think we may define os.EOL by using Object.defineProperty with not configurable and not writable? Then we mark that update with SEMVER-MAJOR?

If we can do that, I'll take this work.

I'm okay with that.

I'd love to address this issue! How can I submit a PR for this?

os: make EOL non-configurable and readonly

@vishal7201

@vishal7201 Sorry but I just saw your reply after I finished the PR.

@XadillaX

No problem @XadillaX

@vishal7201

@vishal7201 How did you discover this? Is this causing issues for you?

@addaleax

@addaleax I was just playing with os module in REPL mode and just figured it out!

os: make EOL configurable and read only

Navigation Menu