Skip to content

1.7.1 --shared-zlib fails #1434

Closed
Closed
1.7.1 --shared-zlib fails#1434
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.confirmed-bugIssues and PRs for confirmed bugs.zlibIssues and PRs related to the zlib module and its compression dependencies.

Description

@Nibbler999
Nibbler999
opened on Apr 15, 2015

#1335 introduced a bug with option handling, it's using code like:

if b(options.shared_zlib) == True:

b returns 'true' or 'false' as a string and 'true' != True, so any builds using --shared-zlib currently fail with a linker error.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.confirmed-bugIssues and PRs for confirmed bugs.zlibIssues and PRs related to the zlib module and its compression dependencies.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions